From: Peter Zijlstra <peterz@infradead.org>
To: Nick Desaulniers <ndesaulniers@google.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Alexander Potapenko <glider@google.com>,
Evgenii Stepanov <eugenis@google.com>,
Kees Cook <keescook@chromium.org>, Marco Elver <elver@google.com>,
Nathan Chancellor <nathan@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Vitaly Buka <vitalybuka@google.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-toolchains <linux-toolchains@vger.kernel.org>
Subject: Re: [PATCH] [RFC] Initialization of unused function parameters
Date: Wed, 15 Jun 2022 00:27:17 +0200 [thread overview]
Message-ID: <YqkLRSBaeb6U1ngW@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <CAKwvOd=C1GC09zobqLK0higE3xPpghWBbB4xujyC8-QDyd_DTQ@mail.gmail.com>
On Tue, Jun 14, 2022 at 11:08:33AM -0700, Nick Desaulniers wrote:
> One thing I'm curious about; if you have an aggregate in C (struct or
> array) and don't fully initialize the whole object, just
> members/sub-objects, but only use those I assume that's not UB? (Which
> is what my maybe_init example does). I think that's fine.
Perf does something like that. We only explicitly initialize the first
cacheline of a structure because that's *always* used. Any other field
will only be initialized on request.
At the time (and i've not benchmarked this in a good few years) that was
a significant performance win.
next prev parent reply other threads:[~2022-06-14 22:27 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-14 14:48 Alexander Potapenko
2022-06-14 16:48 ` Linus Torvalds
2022-06-14 17:11 ` Nick Desaulniers
2022-06-14 17:24 ` Linus Torvalds
2022-06-14 18:08 ` Nick Desaulniers
2022-06-14 22:27 ` Peter Zijlstra [this message]
2022-06-14 18:07 ` Alexander Potapenko
2022-06-14 18:30 ` Linus Torvalds
2022-06-14 20:19 ` Alexander Potapenko
2022-06-14 20:43 ` Linus Torvalds
2022-06-14 21:40 ` Segher Boessenkool
2022-06-14 22:08 ` Evgenii Stepanov
2022-06-15 8:30 ` Alexander Potapenko
2022-06-15 16:46 ` Segher Boessenkool
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YqkLRSBaeb6U1ngW@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=elver@google.com \
--cc=eugenis@google.com \
--cc=glider@google.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-toolchains@vger.kernel.org \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=vitalybuka@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®