Re: [PATCH v1 0/5] power: domain: Add driver for a PM domain provider which controls

[Mark Brown <broonie@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 1242 bytes --]

On Wed, Jun 15, 2022 at 07:24:50PM +0100, Robin Murphy wrote:

> Multiple consumers sharing a voltage rail provided by a single regulator is
> so standard and well-supported that it barely seems worth pointing out, but
> for the avoidance of doubt I shall. Adding a new non-standard way to hide a
> specific subset of regulator functionality behind behind a magic driver
> because it seems like slightly less work than handling it the well-known
> established way sounds like a great recipe for technical debt and future
> compatibility headaches. What if down the line you end up with a situation
> where if device A is suspended, devices B and C are happy to save some power
> by running the "domain" at a lower voltage? Do we stubbornly start
> duplicating more of the regulator framework in the magic power domain
> driver, or is that the point where we have to switch all the consumers to
> explicit supplies, and get to regret having "saved" that effort in the first
> place...

We also loose the runtime validation that the supplies being described
in the DT correspond to the hardware in any meaningful way which would
also make it harder to transition to explicit control of the supplies
further down the line.  

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]