From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 41524C433EF for ; Wed, 15 Jun 2022 21:52:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346451AbiFOVwb (ORCPT ); Wed, 15 Jun 2022 17:52:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43264 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239060AbiFOVw3 (ORCPT ); Wed, 15 Jun 2022 17:52:29 -0400 Received: from mail-pf1-x431.google.com (mail-pf1-x431.google.com [IPv6:2607:f8b0:4864:20::431]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BE998135 for ; Wed, 15 Jun 2022 14:52:27 -0700 (PDT) Received: by mail-pf1-x431.google.com with SMTP id i64so12602158pfc.8 for ; Wed, 15 Jun 2022 14:52:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=0ty1RxSdadl9+9NVwFX4A9nsRzhPnvvUrH+LaNBwqcY=; b=mOTOZ38DU8s4FzE5wLrQa/baN9X5EK/Chdacc1xywG2axFJn81QfX1V4bPIuELWZ54 7ly9GjZPTmsy8LCK2YJVT9ahruaGGsA2w3Zvbyr6hDXHlKeWsVdpye1RcJcaaV7/gYy4 zYRhDLUPdYD6j6CXrK8RPHMOD27iyCam7fboYjf4YCDK2c0LCwQiuu3Xf79EyySoH67N k9fVd2obk+DQ0Y9R6YIQ4/0NwDe6+48zjG7vN29CnhD91xx7oCaGTDWIhl3U8HpsAeFQ QN0b8/UEA0VimsxVYO49LMh1ahxH7QpdwwzX4e2i/0Oq0Sr9XqixhVARtkXJMWmw25ps TsAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=0ty1RxSdadl9+9NVwFX4A9nsRzhPnvvUrH+LaNBwqcY=; b=L1M8iJe2MoIolJKF3MgBlhDtXPTQs30ZJLWmEx15Fiul0Eun52C68NSKsa7yrgcgm8 m61gSMUGN8rR/7B8rbZrq1h5GDiShL5/OV5g3fOmHVw9T0EY4/w+mzS3alcKyHSaWBXU inQHc8LujoKnbFxiUTDnKAX0WoCZN2CSbutfoU/C9eorJClpeKzSskVbhym9PPSL5Eqc 9IGa71FRWqtkxUDxmx094cG2FMehX2q2H+ZhNdl5Nf4cuv5OcNGm8zLrAqZc588LNaNt 6MBeJnGuxUk0jpvaaob5tStGjjeyXd5Ddi2saCBjAu/Uae13dfh0Smrra2tZTjHk55sA 5oHQ== X-Gm-Message-State: AJIora8PJTUVDaEa1ae9ZMFYpwR5UAnRFQs2AVYDSEdkbtswrKr0JfI0 0RIYIuozfHEH+l/W2I3am88DnA== X-Google-Smtp-Source: AGRyM1uI1Sje76zEXKJGG1p78/HpCUSQaVRb3IjIorpckoBM3clSfQzXUTyCe6Ie40563QpO7eiN+g== X-Received: by 2002:a63:8941:0:b0:3fc:7efa:119d with SMTP id v62-20020a638941000000b003fc7efa119dmr1644975pgd.340.1655329947256; Wed, 15 Jun 2022 14:52:27 -0700 (PDT) Received: from google.com ([192.77.111.2]) by smtp.gmail.com with ESMTPSA id f10-20020aa782ca000000b0051bd9981cacsm110643pfn.123.2022.06.15.14.52.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Jun 2022 14:52:26 -0700 (PDT) Date: Wed, 15 Jun 2022 22:52:24 +0100 From: Lee Jones To: AngeloGioacchino Del Regno Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, matthias.bgg@gmail.com, johnson.wang@mediatek.com, hsin-hsiung.wang@mediatek.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] mfd: mt6397: Add basic support for MT6331+MT6332 PMIC Message-ID: References: <20220520124617.228808-1-angelogioacchino.delregno@collabora.com> <20220520124617.228808-3-angelogioacchino.delregno@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220520124617.228808-3-angelogioacchino.delregno@collabora.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 20 May 2022, AngeloGioacchino Del Regno wrote: > Add support for the MT6331 PMIC with MT6332 Companion PMIC, found > in MT6795 Helio X10 smartphone platforms. > > This combo has support for multiple devices but, for a start, > only the following have been implemented: > - Regulators (two instances, one in MT6331, one in MT6332) > - RTC (MT6331) > - Keys (MT6331) > - Interrupts (MT6331 also dispatches MT6332's interrupts) > > There's more to be implemented, especially for MT6332, which > will come at a later stage. > > Signed-off-by: AngeloGioacchino Del Regno > --- > drivers/mfd/mt6397-core.c | 47 ++ > drivers/mfd/mt6397-irq.c | 9 +- > include/linux/mfd/mt6331/core.h | 53 +++ > include/linux/mfd/mt6331/registers.h | 584 ++++++++++++++++++++++++ > include/linux/mfd/mt6332/core.h | 53 +++ > include/linux/mfd/mt6332/registers.h | 642 +++++++++++++++++++++++++++ > include/linux/mfd/mt6397/core.h | 2 + > 7 files changed, 1389 insertions(+), 1 deletion(-) > create mode 100644 include/linux/mfd/mt6331/core.h > create mode 100644 include/linux/mfd/mt6331/registers.h > create mode 100644 include/linux/mfd/mt6332/core.h > create mode 100644 include/linux/mfd/mt6332/registers.h [...] > +#endif /* __MFD_MT6332_REGISTERS_H__ */ > diff --git a/include/linux/mfd/mt6397/core.h b/include/linux/mfd/mt6397/core.h > index 1cf78726503b..4d2b80319db3 100644 > --- a/include/linux/mfd/mt6397/core.h > +++ b/include/linux/mfd/mt6397/core.h > @@ -12,6 +12,8 @@ > > enum chip_id { > MT6323_CHIP_ID = 0x23, > + MT6331_CHIP_ID = 0x20, > + MT6332_CHIP_ID = 0x20, Are these meant to be the same? > MT6358_CHIP_ID = 0x58, > MT6359_CHIP_ID = 0x59, > MT6366_CHIP_ID = 0x66, -- Lee Jones [李琼斯] Principal Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog