From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D9239C433EF for ; Thu, 16 Jun 2022 19:38:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1378436AbiFPTis (ORCPT ); Thu, 16 Jun 2022 15:38:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60056 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1378419AbiFPTir (ORCPT ); Thu, 16 Jun 2022 15:38:47 -0400 Received: from mail-pj1-x1036.google.com (mail-pj1-x1036.google.com [IPv6:2607:f8b0:4864:20::1036]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3D91957159; Thu, 16 Jun 2022 12:38:47 -0700 (PDT) Received: by mail-pj1-x1036.google.com with SMTP id e9so2205287pju.5; Thu, 16 Jun 2022 12:38:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=3mANjjY0moGxiXZnHLX+UHOhvERe+q5moP+dgBuCZ9M=; b=F9CvRl3u0bPQkegn8gRDzTFpWVRsfPRpQInrBIe0BVAlITR/VWYRRA4RaFrE1lJ1BN QxOPr5FPEK7ztGZKRsasgt/szMabvzttgNQVb6YRE/J+GWn8Stg4Vse23xGOe+nL0Vi+ oiTdkNApvaHhAmQdM+bRBQxjIvFtyNw8XoGkJ3auyWS3Je5pWqzGomJkA9LODLwhvxtC lgo3KyUHcvXBM8/Ac5BQIq8v9JKGO45rDaVaEWSRRimbJP0SbQaCElw22ENg/zyshET3 +xY//2BI38BXicqIzmJGJGA2wyWUMOYoi858u/xLbGZkFFq3N1UYF+2HDkHv+i3CUNjp AFUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to; bh=3mANjjY0moGxiXZnHLX+UHOhvERe+q5moP+dgBuCZ9M=; b=oTXBPCCPqpyfjO+jOAFbgFaPE+OUtMYhPNjFUrgocOf2vMQqzLCU4LGLfv87Sn4ttv wctLIqHQdh/N2gpjZc1IBPleTdF0ytJh2TOgo95SsK+su3O70A4g5pkZKMVRQpFZPapi qjMsAAilgtL1mZuyRZEk54tpMJtjx67IswF185XwkAaNhEiXiCgqL6KyJJ6oFZqlgORS Ogxusm7LvWP1vXAWdmFP/3PkLP5lDumGTddaJ0LypEJKatOiM9gZAUlR/0aTYV8ZTfPb /S2Xlli8v3J4ZcHixNzUAHhYLz3Zq0MfOmrwA9vlalV9cSmgNgTnrYgSCtoz5TvwBu2/ y3gw== X-Gm-Message-State: AJIora+TVWPK+AqDL4PPUidmmu7yniakuL5Ncg5MD2nnOsQWImCtGemm JeOrSqBULZAR/SK3nThVGsQ= X-Google-Smtp-Source: AGRyM1sK5DS6R3nuQSXiuNFAv5tzrx8Y+NYiYuVnj2DYE5e2vGjO1uAj8Df9AuNCkIKdsfJrOS9lHA== X-Received: by 2002:a17:902:ea03:b0:166:ab55:d7ee with SMTP id s3-20020a170902ea0300b00166ab55d7eemr5940058plg.103.1655408326629; Thu, 16 Jun 2022 12:38:46 -0700 (PDT) Received: from localhost ([2620:10d:c090:400::4:330c]) by smtp.gmail.com with ESMTPSA id s2-20020a17090302c200b00163fa4b7c12sm1882140plk.34.2022.06.16.12.38.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Jun 2022 12:38:46 -0700 (PDT) Sender: Tejun Heo Date: Thu, 16 Jun 2022 09:38:44 -1000 From: Tejun Heo To: Mukesh Ojha Cc: paulmck@kernel.org, lkml , cgroups@vger.kernel.org, brauner@kernel.org, hannes@cmpxchg.org, shisiyuan , Li Zefan , Michal =?iso-8859-1?Q?Koutn=FD?= Subject: Re: [PATCH cgroup/for-5.19-fixes] cgroup: Use separate src/dst nodes when preloading css_sets for migration Message-ID: References: <549de740-1356-7ad2-3ee5-c52bc355fd99@quicinc.com> <8d21e655-4ce9-c7b3-2010-e484161bdbe9@quicinc.com> <20220516203417.GY1790663@paulmck-ThinkPad-P17-Gen-1> <9a93cf2d-0efe-5a46-dcd5-7dcd8f173188@quicinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 13, 2022 at 12:19:50PM -1000, Tejun Heo wrote: > Each cset (css_set) is pinned by its tasks. When we're moving tasks around > across csets for a migration, we need to hold the source and destination > csets to ensure that they don't go away while we're moving tasks about. This > is done by linking cset->mg_preload_node on either the > mgctx->preloaded_dst_csets or mgctx->preloaded_dst_csets list. Using the > same cset->mg_preload_node for both the src and dst lists was deemed okay as > a cset can't be both the source and destination at the same time. Applied to cgroup/for-5.19-fixes w/ patch description fixed. Thanks. -- tejun