On Wed, Jun 15, 2022 at 04:00:17PM +0200, Arnd Bergmann wrote: > On Thu, Jun 9, 2022 at 11:35 PM Jonathan Neuschäfer > wrote: > > > > Add a SoC information driver for Nuvoton WPCM450 SoCs. It provides > > information such as the SoC revision. > > > > Usage example: > > > > # grep . /sys/devices/soc0/* > > /sys/devices/soc0/family:Nuvoton NPCM > > /sys/devices/soc0/revision:A3 > > /sys/devices/soc0/soc_id:WPCM450 > > > > Signed-off-by: Jonathan Neuschäfer > > Reviewed-by: Joel Stanley > > Reviewed-by: Paul Menzel > > Looks good overall. > > > +menuconfig WPCM450_SOC > > + bool "Nuvoton WPCM450 SoC driver" > > + default y if ARCH_WPCM450 > > It would be nice to make this a tristate option, as we generally > like to keep optional drivers out of the allmodconfig vmlinux file, > even if this is a tiny one. Ok. > Just add the trivial cleanup function and MODULE_LICENSE() etc tags. The right thing to do seems to be to unregister the SoC device in the cleanup function. Is that what you mean? Jonathan