From: Petr Mladek <pmladek@suse.com>
To: Valentin Schneider <vschneid@redhat.com>
Cc: Tao Zhou <tao.zhou@linux.dev>,
linux-kernel@vger.kernel.org, kexec@lists.infradead.org,
linux-rt-users@vger.kernel.org,
Eric Biederman <ebiederm@xmission.com>,
Arnd Bergmann <arnd@arndb.de>,
Thomas Gleixner <tglx@linutronix.de>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
Juri Lelli <jlelli@redhat.com>,
"Luis Claudio R. Goncalves" <lgoncalv@redhat.com>
Subject: Re: [PATCH] panic, kexec: Don't mutex_trylock() in __crash_kexec()
Date: Fri, 17 Jun 2022 15:52:27 +0200 [thread overview]
Message-ID: <YqyHGxPCgiXuep3/@alley> (raw)
In-Reply-To: <xhsmhh74j7biy.mognet@vschneid.remote.csb>
On Fri 2022-06-17 12:52:05, Valentin Schneider wrote:
> Hi Tao,
>
> On 17/06/22 18:42, Tao Zhou wrote:
> > Hi Valentin,
> >
> > On Thu, Jun 16, 2022 at 01:37:09PM +0100, Valentin Schneider wrote:
> >> @@ -964,24 +966,31 @@ late_initcall(kexec_core_sysctl_init);
> >> */
> >> void __noclone __crash_kexec(struct pt_regs *regs)
> >> {
> >> - /* Take the kexec_mutex here to prevent sys_kexec_load
> >> - * running on one cpu from replacing the crash kernel
> >> - * we are using after a panic on a different cpu.
> >> + /*
> >> + * This should be taking kexec_mutex before doing anything with the
> >> + * kexec_crash_image, but this code can be run in NMI context which
> >> + * means we can't even trylock.
> >> *
> >> - * If the crash kernel was not located in a fixed area
> >> - * of memory the xchg(&kexec_crash_image) would be
> >> - * sufficient. But since I reuse the memory...
> >> + * Pairs with smp_mb() in do_kexec_load() and sys_kexec_file_load()
> >> */
> >> - if (mutex_trylock(&kexec_mutex)) {
> >> - if (kexec_crash_image) {
> >> - struct pt_regs fixed_regs;
> >> -
> >> - crash_setup_regs(&fixed_regs, regs);
> >> - crash_save_vmcoreinfo();
> >> - machine_crash_shutdown(&fixed_regs);
> >> - machine_kexec(kexec_crash_image);
> >> - }
> >> - mutex_unlock(&kexec_mutex);
> >> + WRITE_ONCE(panic_wants_kexec, true);
> >> + smp_mb();
> >> + /*
> >> + * If we're panic'ing while someone else is messing with the crash
> >> + * kernel, this isn't going to end well.
> >> + */
> >> + if (READ_ONCE(kexec_loading)) {
> >> + WRITE_ONCE(panic_wants_kexec, false);
> >> + return;
> >> + }
> >
> > So this is from NMI. The mutex guarantee that kexec_file_load() or
> > do_kexec_load() just one of them beat on cpu. NMI can happen on more
> > than one cpu. That means that here be cumulativity here IMHO.
> >
>
> If you look at __crash_kexec() in isolation yes, but if you look at panic()
> and nmi_panic() only a single NMI can get in there. I think that is also
> true for invocations via crash_kexec().
It is true that panic() could be called only once, see this code
in panic():
* Only one CPU is allowed to execute the panic code from here. For
this_cpu = raw_smp_processor_id();
old_cpu = atomic_cmpxchg(&panic_cpu, PANIC_CPU_INVALID, this_cpu);
if (old_cpu != PANIC_CPU_INVALID && old_cpu != this_cpu)
panic_smp_self_stop();
One the other hand, the aproach with two variables is strage
and brings exactly these questions.
If a trylock is enough that the mutex can be replaced by two
simple atomic operations. The mutex would be needed only
when a user really would need to wait for another one.
atomic_t crash_kexec_lock;
/* trylock part */
if (atomic_cmpxchg_acquire(&crash_kexec_lock, 0, 1) != 0)
return -EBUSY;
/* do anything guarded by crash_kexec_lock */
/* release lock */
atomic_set_release(&crash_kexec_lock, 0);
The _acquire, _release variants will do the barriers correctly.
Best Regards,
Petr
next prev parent reply other threads:[~2022-06-17 13:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-16 12:37 Valentin Schneider
2022-06-17 10:42 ` Tao Zhou
2022-06-17 11:52 ` Valentin Schneider
2022-06-17 13:52 ` Petr Mladek [this message]
2022-06-17 14:46 ` Valentin Schneider
2022-06-17 15:13 ` Sebastian Andrzej Siewior
2022-06-17 16:09 ` Valentin Schneider
2022-06-17 16:53 ` Sebastian Andrzej Siewior
2022-06-22 15:34 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YqyHGxPCgiXuep3/@alley \
--to=pmladek@suse.com \
--cc=arnd@arndb.de \
--cc=bigeasy@linutronix.de \
--cc=ebiederm@xmission.com \
--cc=jlelli@redhat.com \
--cc=kexec@lists.infradead.org \
--cc=lgoncalv@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=tao.zhou@linux.dev \
--cc=tglx@linutronix.de \
--cc=vschneid@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®