mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: zys.zljxml@gmail.com
Cc: tj@kernel.org, viro@zeniv.linux.org.uk,
	linux-kernel@vger.kernel.org, katrinzhou <katrinzhou@tencent.com>
Subject: Re: [PATCH] kernfs: fix potential NULL dereference in __kernfs_remove
Date: Thu, 30 Jun 2022 09:28:06 +0200	[thread overview]
Message-ID: <Yr1QhjNGVJ7oPpRX@kroah.com> (raw)
In-Reply-To: <20220630040047.3241781-1-zys.zljxml@gmail.com>

On Thu, Jun 30, 2022 at 12:00:47PM +0800, zys.zljxml@gmail.com wrote:
> From: katrinzhou <katrinzhou@tencent.com>
> 
> When lockdep is enabled, lockdep_assert_held_write would
> cause potential NULL pointer dereference.
> 
> Fix the folloeing smatch warnings:
> 
> fs/kernfs/dir.c:1353 __kernfs_remove() warn: variable dereferenced before check 'kn' (see line 1346)
> 
> Signed-off-by: katrinzhou <katrinzhou@tencent.com>

Can you please submit this with your legal name that you use to sign
documents?

Also, what commit id does this fix?  Did you actually hit this with a
real workload?  How can this be reproduced and tested?

thanks,

greg k-h

  reply	other threads:[~2022-06-30  7:28 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-30  4:00 zys.zljxml
2022-06-30  7:28 ` Greg KH [this message]
2022-06-30  8:12   ` Katrin Jo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Yr1QhjNGVJ7oPpRX@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=katrinzhou@tencent.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tj@kernel.org \
    --cc=viro@zeniv.linux.org.uk \
    --cc=zys.zljxml@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®