mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Yangxi Xiang <xyangxi5@gmail.com>
Cc: linux-kernel@vger.kernel.org, Jiri Slaby <jirislaby@kernel.org>,
	Johan Hovold <johan@kernel.org>,
	Igor Matheus Andrade Torrente <igormtorrente@gmail.com>,
	Christian Borntraeger <borntraeger@linux.ibm.com>,
	nick black <dankamongmen@gmail.com>
Subject: Re: [PATCH v3] vt: fix memory overlapping when deleting chars in the buffer
Date: Thu, 30 Jun 2022 17:18:11 +0200	[thread overview]
Message-ID: <Yr2+s6wQWSfq/Gl5@kroah.com> (raw)
In-Reply-To: <20220628093322.5688-1-xyangxi5@gmail.com>

On Tue, Jun 28, 2022 at 05:33:22PM +0800, Yangxi Xiang wrote:
> A memory overlapping copy occurs when deleting a long line. This memory
> overlapping copy can cause data corruption when scr_memcpyw is optimized
> to memcpy because memcpy does not ensure its behavior if the destination
> buffer overlaps with the source buffer. The line buffer is not always
> broken, because the memcpy utilizes the hardware acceleration, whose
> result is not deterministic.
> 
> Fix this problem by using replacing the scr_memcpyw with scr_memmovew.
> 
> Fixes: 81732c3b2fed ("Fix line garbage in virtual console")

Nit, this should have been:
	Fixes: 81732c3b2fed ("tty vt: Fix line garbage in virtual console on command line edition")

otherwise our tools complain.  I've fixed it up when applying it.

thanks,

greg k-h

      reply	other threads:[~2022-06-30 15:18 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-28  9:33 Yangxi Xiang
2022-06-30 15:18 ` Greg Kroah-Hartman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Yr2+s6wQWSfq/Gl5@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=borntraeger@linux.ibm.com \
    --cc=dankamongmen@gmail.com \
    --cc=igormtorrente@gmail.com \
    --cc=jirislaby@kernel.org \
    --cc=johan@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=xyangxi5@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®