From: Mark Brown <broonie@kernel.org>
To: Vijendar Mukunda <Vijendar.Mukunda@amd.com>
Cc: alsa-devel@alsa-project.org, dri-devel@lists.freedesktop.org,
amd-gfx@lists.freedesktop.org, Alexander.Deucher@amd.com,
Basavaraj.Hiregoudar@amd.com, Sunil-kumar.Dommati@amd.com,
zhuning@everest-semi.com, Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 4/5] ASoC: amd: add Machine driver for Jadeite platform
Date: Thu, 30 Jun 2022 12:10:35 +0100 [thread overview]
Message-ID: <Yr2Eq0BUmi6mZsRY@sirena.org.uk> (raw)
In-Reply-To: <20220630031755.1055413-5-Vijendar.Mukunda@amd.com>
[-- Attachment #1: Type: text/plain, Size: 777 bytes --]
On Thu, Jun 30, 2022 at 08:47:54AM +0530, Vijendar Mukunda wrote:
> +static int st_es8336_hw_params(struct snd_pcm_substream *substream,
> + struct snd_pcm_hw_params *params)
> +{
> + int ret = 0;
> + struct snd_soc_pcm_runtime *rtd = asoc_substream_to_rtd(substream);
> + struct snd_soc_dai *codec_dai = asoc_rtd_to_codec(rtd, 0);
> +
> + ret = snd_soc_dai_set_sysclk(codec_dai, 0, params_rate(params) * 256, SND_SOC_CLOCK_IN);
> + if (ret < 0) {
> + dev_err(rtd->dev, "can't set codec sysclk: %d\n", ret);
> + return ret;
> + }
> + return ret;
> +}
> +static const unsigned int st_channels[] = {
> + DUAL_CHANNEL,
> +};
> +
> +static const unsigned int st_rates[] = {
> + 48000,
> +};
If the clock rate is fixed why not just set the sysclk once at startup
too?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2022-06-30 11:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20220630031755.1055413-1-Vijendar.Mukunda@amd.com>
2022-06-30 3:17 ` [PATCH 1/5] drm/amdgpu: add dmi check for jadeite platform Vijendar Mukunda
2022-06-30 3:17 ` [PATCH 2/5] drm/amdgpu: create I2S platform devices for Jadeite platform Vijendar Mukunda
2022-06-30 3:17 ` [PATCH 3/5] ASoC: amd: add I2S MICSP instance support Vijendar Mukunda
2022-06-30 3:17 ` [PATCH 4/5] ASoC: amd: add Machine driver for Jadeite platform Vijendar Mukunda
2022-06-30 11:10 ` Mark Brown [this message]
2022-06-30 18:36 ` Mukunda,Vijendar
2022-06-30 3:17 ` [PATCH 5/5] ASoC: amd: enable machine driver build " Vijendar Mukunda
2022-06-30 11:11 ` Mark Brown
2022-06-30 18:32 ` Mukunda,Vijendar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yr2Eq0BUmi6mZsRY@sirena.org.uk \
--to=broonie@kernel.org \
--cc=Alexander.Deucher@amd.com \
--cc=Basavaraj.Hiregoudar@amd.com \
--cc=Sunil-kumar.Dommati@amd.com \
--cc=Vijendar.Mukunda@amd.com \
--cc=alsa-devel@alsa-project.org \
--cc=amd-gfx@lists.freedesktop.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
--cc=zhuning@everest-semi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®