From: Greg KH <gregkh@linuxfoundation.org>
To: "D. Starke" <daniel.starke@siemens.com>
Cc: linux-serial@vger.kernel.org, jirislaby@kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 1/9] tty: n_gsm: fix user open not possible at responder until initiator open
Date: Fri, 1 Jul 2022 10:08:07 +0200 [thread overview]
Message-ID: <Yr6rZy1+/ZHxOK+P@kroah.com> (raw)
In-Reply-To: <20220701061652.39604-1-daniel.starke@siemens.com>
On Fri, Jul 01, 2022 at 08:16:44AM +0200, D. Starke wrote:
> From: Daniel Starke <daniel.starke@siemens.com>
>
> After setting up the control channel on both sides the responder side may
> want to open a virtual tty to listen on until the initiator starts an
> application on a user channel. The current implementation allows the
> open() but no other operation, like termios. These fail with EINVAL.
> The responder sided application has no means to detect an open by the
> initiator sided application this way. And the initiator sided applications
> usually expect the responder sided application to listen on the user
> channel upon open.
> Set the user channel into half-open state on responder side once a user
> application opens the virtual tty to allow IO operations on it.
> Furthermore, keep the user channel constipated until the initiator side
> opens it to give the responder sided application the chance to detect the
> new connection and to avoid data loss if the responder sided application
> starts sending before the user channel is open.
>
> Fixes: e1eaea46bb40 ("tty: n_gsm line discipline")
> Signed-off-by: Daniel Starke <daniel.starke@siemens.com>
> ---
> drivers/tty/n_gsm.c | 31 +++++++++++++++++++++++++++++--
> 1 file changed, 29 insertions(+), 2 deletions(-)
>
> Stable backport remark has been removed compared to v3. No other changes applied.
>
> Link: https://lore.kernel.org/all/20220530144512.2731-1-daniel.starke@siemens.com/
Not all patches in this series would apply to my tree. Please rebase
the remaining ones and resend.
thanks,
greg k-h
prev parent reply other threads:[~2022-07-01 8:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-01 6:16 D. Starke
2022-07-01 6:16 ` [PATCH v4 2/9] tty: n_gsm: fix tty registration before control channel open D. Starke
2022-07-01 6:16 ` [PATCH v4 3/9] tty: n_gsm: fix wrong queuing behavior in gsm_dlci_data_output() D. Starke
2022-07-01 6:16 ` [PATCH v4 4/9] tty: n_gsm: fix missing timer to handle stalled links D. Starke
2022-07-01 6:16 ` [PATCH v4 5/9] tty: n_gsm: fix non flow control frames during mux flow off D. Starke
2022-07-01 6:16 ` [PATCH v4 6/9] tty: n_gsm: fix deadlock and link starvation in outgoing data path D. Starke
2022-07-01 6:16 ` [PATCH v4 7/9] tty: n_gsm: fix packet re-transmission without open control channel D. Starke
2022-07-01 6:16 ` [PATCH v4 8/9] tty: n_gsm: fix resource allocation order in gsm_activate_mux() D. Starke
2022-07-01 6:16 ` [PATCH v4 9/9] tty: n_gsm: fix race condition in gsmld_write() D. Starke
2022-07-01 8:08 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yr6rZy1+/ZHxOK+P@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=daniel.starke@siemens.com \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®