From: "Jason A. Donenfeld" <Jason@zx2c4.com>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
dave.hansen@linux.intel.com, x86@kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5] x86/setup: Allow passing RNG seeds via e820 setup table
Date: Fri, 1 Jul 2022 20:42:03 +0200 [thread overview]
Message-ID: <Yr8/+3qha3nCRLOD@zx2c4.com> (raw)
In-Reply-To: <05A1E6F8-432A-4D68-9CF8-C77A3FC68584@zytor.com>
Hi Peter,
On Fri, Jul 01, 2022 at 11:25:49AM -0700, H. Peter Anvin wrote:
> Please correct the incredibly confusing title of this patch.
>
> The setup_data linked list has nothing to do with memory types (e820),
> except that memory types is one kind of data that can be passed on by
> this mechanism. This title makes it sound like you are passing random
> data in as a memory type, which could make some bizarre sense if it
> were, say, some kind of ring buffer preconfigured by the BIOS/VMM/boot
> loader to be continually overwritten with new random data.
Yea that is pretty confusing. Alright, I'll retitle that to something
like:
x86/setup: Allow passing RNG seeds via setup data
Hopefully that matches more, considering the function that does the work
is called "parse_setup_data".
(I'll wait some more time before posting yet another v+1 with that
change, in case others have more feedback.)
Jason
next prev parent reply other threads:[~2022-07-01 18:42 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-30 11:33 [PATCH] " Jason A. Donenfeld
2022-06-30 11:59 ` [PATCH v2] " Jason A. Donenfeld
2022-06-30 12:09 ` [PATCH v3] " Jason A. Donenfeld
2022-06-30 13:31 ` [PATCH v4] " Jason A. Donenfeld
2022-07-01 17:58 ` [PATCH v5] " Jason A. Donenfeld
2022-07-01 18:25 ` H. Peter Anvin
2022-07-01 18:42 ` Jason A. Donenfeld [this message]
2022-07-01 18:52 ` H. Peter Anvin
2022-07-01 18:53 ` Jason A. Donenfeld
2022-07-03 0:44 ` [PATCH v6] x86/setup: Use rng seeds from setup_data Jason A. Donenfeld
2022-07-07 0:08 ` [PATCH v7] " Jason A. Donenfeld
2022-07-08 11:39 ` [PATCH tip v8] " Jason A. Donenfeld
2022-07-09 1:51 ` H. Peter Anvin
2022-07-09 9:43 ` Jason A. Donenfeld
2022-07-09 9:48 ` [PATCH tip v9] " Jason A. Donenfeld
2022-07-09 22:42 ` H. Peter Anvin
2022-07-09 23:23 ` Jason A. Donenfeld
2022-07-09 9:49 ` [PATCH tip v8] " Borislav Petkov
2022-07-09 9:53 ` Jason A. Donenfeld
2022-07-09 10:21 ` Borislav Petkov
2022-07-09 21:45 ` H. Peter Anvin
2022-07-09 21:57 ` Borislav Petkov
2022-07-09 22:41 ` H. Peter Anvin
2022-07-10 9:45 ` Borislav Petkov
2022-07-10 11:11 ` Jason A. Donenfeld
2022-07-10 12:27 ` Borislav Petkov
2022-07-10 17:13 ` Jason A. Donenfeld
2022-07-10 17:29 ` [PATCH tip v10] " Jason A. Donenfeld
2022-07-11 9:39 ` [tip: x86/kdump] " tip-bot2 for Jason A. Donenfeld
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yr8/+3qha3nCRLOD@zx2c4.com \
--to=jason@zx2c4.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®