From: Luis Chamberlain <mcgrof@kernel.org>
To: Lucas De Marchi <lucas.demarchi@intel.com>
Cc: linux-modules <linux-modules@vger.kernel.org>,
lkml <linux-kernel@vger.kernel.org>
Subject: Re: [ANNOUNCE] kmod 30
Date: Fri, 1 Jul 2022 10:49:10 -0700 [thread overview]
Message-ID: <Yr8zlqicFErzw0dc@bombadil.infradead.org> (raw)
In-Reply-To: <20220630223323.2hko2imx62embtsj@ldmartin-desk2>
On Thu, Jun 30, 2022 at 03:33:23PM -0700, Lucas De Marchi wrote:
> On Thu, Jun 30, 2022 at 03:09:32PM -0700, Luis Chamberlain wrote:
> > Sorry for the super late review, I was swamped. OK so the only issue
> > I can think of is that rmmod *used* to support the kernel wait support
> > with $(rmmod --wait) so wouldn't this be odd?
>
> any reason not to use modprobe -r?
I was referring to old scripts which may have used $(rmmod --wait) before.
But since support for that was ripped, then yeah I can see that should
not be an issue.
However I can think of *one* issue, did we ever support `modprobe--wait`?
Because the way fstests / blktests would implement this feature
detection is with something like this now:
_has_modprobe_patient()
{
modprobe --help >& /dev/null || return 1
modprobe --help | grep -q -1 "remove-patiently" || return 1
return 0
}
> > It is why I had gone with:
> >
> > -p | --remove-patiently patiently removes the module
> > -t | --timeout timeout in ms to remove the module
> >
> > You would know better though.
> >
> > Also just curious, is it really terrible to just support waiting
> > forever?
>
> is there a use case for that? If we are trying to cover some races, I
> imagine a small timeout would be sufficient. Also notice that if the
> timeout is too big, so will be the interval between the retries. On
> your v2 I had suggested polling the refcnt so we would get notificed
> on changes, but as you also noticed, that didn't work very well. So I
> went back to a time-based retry solution.
>
> if there is a use-case, should we cap the interval between retries?
I really can't think of a use case except for catching glaring
unexpected bugs in test suites where the kernel developer would
really like to know something really bad happened, but even then
a timeout is likely desirable.
So just a heads up the timeout I'll use for fstests / blktests will be
of 100 seconds.
Thanks for this work!
Luis
next prev parent reply other threads:[~2022-07-01 17:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-30 15:36 Lucas De Marchi
2022-06-30 22:09 ` Luis Chamberlain
2022-06-30 22:33 ` Lucas De Marchi
2022-07-01 17:49 ` Luis Chamberlain [this message]
2022-07-01 18:13 ` Lucas De Marchi
2022-07-01 21:25 ` Luis Chamberlain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yr8zlqicFErzw0dc@bombadil.infradead.org \
--to=mcgrof@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-modules@vger.kernel.org \
--cc=lucas.demarchi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®