mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Luis Chamberlain <mcgrof@kernel.org>
To: Aaron Tomlin <atomlin@redhat.com>
Cc: Steven Rostedt <rostedt@goodmis.org>,
	christophe.leroy@csgroup.eu, cl@linux.com, mbenes@suse.cz,
	akpm@linux-foundation.org, jeyu@kernel.org,
	linux-kernel@vger.kernel.org, linux-modules@vger.kernel.org,
	void@manifault.com, atomlin@atomlin.com, allen.lkml@gmail.com,
	joe@perches.com, msuchanek@suse.de, oleksandr@natalenko.name,
	jason.wessel@windriver.com, pmladek@suse.com,
	daniel.thompson@linaro.org, hch@infradead.org,
	Chuck Lever III <chuck.lever@oracle.com>
Subject: Re: [PATCH v11 09/14] module: Move kallsyms support into a separate file
Date: Fri, 1 Jul 2022 15:34:10 -0700	[thread overview]
Message-ID: <Yr92YtG12f+II+ea@bombadil.infradead.org> (raw)
In-Reply-To: <20220628081906.jln2ombfej5473xi@ava.usersys.com>

On Tue, Jun 28, 2022 at 09:19:06AM +0100, Aaron Tomlin wrote:
> On Tue 2022-06-28 00:05 -0400, Steven Rostedt wrote:
> > On Thu, 10 Mar 2022 10:24:08 +0000
> > Aaron Tomlin <atomlin@redhat.com> wrote:
> > 
> > > No functional change.
> > > 
> > 
> > And this too has a functional change as well.
> > 
> > Reported-by: Chuck Lever III <chuck.lever@oracle.com>
> > Link: https://lore.kernel.org/all/355D2478-33D3-4046-8422-E512F42C51BC@oracle.com/
> > 
> > 
> > Before this patch:
> > 
> >  # grep -a '^[0-9a-f]* [^a-zA-Z]' /proc/kallsyms
> > 
> > Nothing.
> > 
> > After this patch:
> > 
> >  # grep -a '^[0-9a-f]* [^a-zA-Z]' /proc/kallsyms
> > ffffffffc09df024 ^@ _note_9     [ebtables]
> > ffffffffc09df03c ^@ _note_8     [ebtables]
> > ffffffffc0e25024 ^@ _note_9     [bridge]
> > ffffffffc0e2503c ^@ _note_8     [bridge]
> > ffffffffc0e01000 ^@ br_switchdev_event  [bridge]
> > ffffffffc0e39548 ^@ __warned.10 [bridge]
> > ffffffffc09bd024 ^@ _note_9     [stp]
> > ffffffffc09bd03c ^@ _note_8     [stp]
> > ffffffffc0849024 ^@ _note_9     [vmw_vmci]
> > ffffffffc084903c ^@ _note_8     [vmw_vmci]
> > ffffffffc0849454 ^@ __kstrtab_vmci_context_get_priv_flags       [vmw_vmci]
> > ffffffffc0849470 ^@ __kstrtabns_vmci_context_get_priv_flags     [vmw_vmci]
> > ffffffffc0849054 ^@ __ksymtab_vmci_context_get_priv_flags       [vmw_vmci]
> > ffffffffc081d024 ^@ _note_9     [nf_reject_ipv6]
> > ffffffffc081d03c ^@ _note_8     [nf_reject_ipv6]
> > ffffffffc081d0a8 ^@ __kstrtab_nf_reject_skb_v6_tcp_reset        [nf_reject_ipv6]
> > ffffffffc081d0c3 ^@ __kstrtabns_nf_reject_skb_v6_tcp_reset      [nf_reject_ipv6]
> > ffffffffc081d078 ^@ __ksymtab_nf_reject_skb_v6_tcp_reset        [nf_reject_ipv6]
> > ffffffffc081d0c4 ^@ __kstrtab_nf_reject_skb_v6_unreach  [nf_reject_ipv6]
> > 
> > The kallsyms get corrupted output, and this breaks trace-cmd.
> 
> Hi Steve,
> 
> I will look into this straight away.

Poke, did you get to implement this yet?

  Luis

  reply	other threads:[~2022-07-01 22:34 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-10 10:23 [PATCH v11 00/14] module: core code clean up Aaron Tomlin
2022-03-10 10:24 ` [PATCH v11 01/14] module: Move all into module/ Aaron Tomlin
2022-03-10 10:24 ` [PATCH v11 02/14] module: Simple refactor in preparation for split Aaron Tomlin
2022-03-10 10:24 ` [PATCH v11 03/14] module: Make internal.h and decompress.c more compliant Aaron Tomlin
2022-03-10 10:24 ` [PATCH v11 04/14] module: Move livepatch support to a separate file Aaron Tomlin
2022-03-10 10:24 ` [PATCH v11 05/14] module: Move latched RB-tree " Aaron Tomlin
2022-03-10 10:24 ` [PATCH v11 06/14] module: Move strict rwx " Aaron Tomlin
2022-03-10 10:24 ` [PATCH v11 07/14] module: Move extra signature support out of core code Aaron Tomlin
2022-03-10 10:24 ` [PATCH v11 08/14] module: Move kmemleak support to a separate file Aaron Tomlin
2022-03-10 10:24 ` [PATCH v11 09/14] module: Move kallsyms support into " Aaron Tomlin
2022-06-28  4:05   ` Steven Rostedt
2022-06-28  8:19     ` Aaron Tomlin
2022-07-01 22:34       ` Luis Chamberlain [this message]
2022-07-03  8:33         ` Aaron Tomlin
2022-07-03 13:23           ` Steven Rostedt
2022-07-03 13:57             ` Aaron Tomlin
2022-07-03 14:13               ` Steven Rostedt
2022-07-03 14:24                 ` Aaron Tomlin
2022-07-03 17:58                 ` Christophe Leroy
2022-07-03 23:18                   ` Steven Rostedt
2022-03-10 10:24 ` [PATCH v11 10/14] module: kallsyms: Fix suspicious rcu usage Aaron Tomlin
2022-06-28  3:56   ` Steven Rostedt
2022-06-28 16:21     ` Aaron Tomlin
2022-06-28 16:24       ` Steven Rostedt
2022-03-10 10:24 ` [PATCH v11 11/14] module: Move procfs support into a separate file Aaron Tomlin
2022-03-10 10:26 ` [PATCH v11 12/14] module: Move sysfs " Aaron Tomlin
2022-03-10 10:26   ` [PATCH v11 13/14] module: Move kdb module related code out of main kdb code Aaron Tomlin
2022-03-11 16:17     ` Daniel Thompson
2022-03-11 18:00       ` Luis Chamberlain
2022-03-10 10:26   ` [PATCH v11 14/14] module: Move version support into a separate file Aaron Tomlin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Yr92YtG12f+II+ea@bombadil.infradead.org \
    --to=mcgrof@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=allen.lkml@gmail.com \
    --cc=atomlin@atomlin.com \
    --cc=atomlin@redhat.com \
    --cc=christophe.leroy@csgroup.eu \
    --cc=chuck.lever@oracle.com \
    --cc=cl@linux.com \
    --cc=daniel.thompson@linaro.org \
    --cc=hch@infradead.org \
    --cc=jason.wessel@windriver.com \
    --cc=jeyu@kernel.org \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-modules@vger.kernel.org \
    --cc=mbenes@suse.cz \
    --cc=msuchanek@suse.de \
    --cc=oleksandr@natalenko.name \
    --cc=pmladek@suse.com \
    --cc=rostedt@goodmis.org \
    --cc=void@manifault.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®