From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5E56AC43334 for ; Mon, 20 Jun 2022 09:42:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240469AbiFTJmr (ORCPT ); Mon, 20 Jun 2022 05:42:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47676 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240559AbiFTJmn (ORCPT ); Mon, 20 Jun 2022 05:42:43 -0400 Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7755E13DFF for ; Mon, 20 Jun 2022 02:42:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1655718160; x=1687254160; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=nqwcpRJEPXMSpAq5T9rlPN8eIacQEWEJX0zhcrKDNOg=; b=BHrUL6Ux0FbIifCoJ6z2NyOZi67Hy57UbzjNiPSo1hL4Kd+K3YPNQGtm xzOrisRy3j2tA8HP9FLqFgdMf0kVBOm+GgFQAAkNQlbbBk57mMw2xNai9 jODUJu5cEimiFHMy4DwbkuoPQ8L0QpIw76vWinveGDZTHel60NS2vIB+T Yggsdd1o3UvbvGM85rUtI/pi6oR2ICFG3LVO5/j2R3FVIV5hb2hoGF5/8 EbxvSQM1FAIVXQly8BuE5VS1qIt24NljNPMTtqhpMhRlACwplInpXqS7b JdsMPak6UjNAF4UXnFm2ok2MCj0TM8iqDeEAGCzUSozjFlaau6P5INhTf w==; X-IronPort-AV: E=McAfee;i="6400,9594,10380"; a="280582462" X-IronPort-AV: E=Sophos;i="5.92,306,1650956400"; d="scan'208";a="280582462" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Jun 2022 02:42:22 -0700 X-IronPort-AV: E=Sophos;i="5.92,306,1650956400"; d="scan'208";a="833035732" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga006-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Jun 2022 02:42:20 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.95) (envelope-from ) id 1o3DvG-000h2g-6G; Mon, 20 Jun 2022 12:42:18 +0300 Date: Mon, 20 Jun 2022 12:42:17 +0300 From: Andy Shevchenko To: Hans de Goede Cc: Lee Jones , linux-kernel@vger.kernel.org, Andy Shevchenko Subject: Re: [PATCH v1 1/9] mfd: intel_soc_pmic_crc: Merge Intel PMIC core to crc Message-ID: References: <20220616182524.7956-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 20, 2022 at 10:51:33AM +0200, Hans de Goede wrote: > Hi, > > Thank you for this series, cleaning this up is long overdue. > > The entire series looks good to me: > > Reviewed-by: Hans de Goede > > for the series. Thanks! > Maybe do a follow up renaming CONFIG_INTEL_SOC_PMIC to > CONFIG_INTEL_SOC_PMIC_CRC and also change the module name > from intel-soc-pmic to intel-soc-pmic-crc ? I thought about that, but decided to leave it for later since it will take a lot of subsystems and better to be considered out of the scope of this series. Do you agree? > I don't expect any userspace dependencies on the module-name > (there are no module parameters) so this should be fine. -- With Best Regards, Andy Shevchenko