From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Zheng Bin <zhengbin13@huawei.com>
Cc: andrew@lunn.ch, hkallweit1@gmail.com, davem@davemloft.net,
edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
boon.leong.ong@intel.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, gaochao49@huawei.com
Subject: Re: [PATCH -next] net: pcs: pcs-xpcs: Fix build error when CONFIG_PCS_XPCS=y && CONFIG_PHYLINK=m
Date: Tue, 21 Jun 2022 14:29:45 +0100 [thread overview]
Message-ID: <YrHHyZNJXVme1JIe@shell.armlinux.org.uk> (raw)
In-Reply-To: <20220621131251.3357104-1-zhengbin13@huawei.com>
On Tue, Jun 21, 2022 at 09:12:51PM +0800, Zheng Bin wrote:
> If CONFIG_PCS_XPCS=y, CONFIG_PHYLINK=m, bulding fails:
>
> drivers/net/pcs/pcs-xpcs.o: in function `xpcs_do_config':
> pcs-xpcs.c:(.text+0x64f): undefined reference to `phylink_mii_c22_pcs_encode_advertisement'
> drivers/net/pcs/pcs-xpcs.o: in function `xpcs_get_state':
> pcs-xpcs.c:(.text+0x10f8): undefined reference to `phylink_mii_c22_pcs_decode_state
>
> Make PCS_XPCS depends on PHYLINK to fix this.
>
> Fixes: b47aec885bcd ("net: pcs: xpcs: add CL37 1000BASE-X AN support")
> Signed-off-by: Zheng Bin <zhengbin13@huawei.com>
Paolo Abeni has already sent a patch, which I think is addressing a
similar issue. Please see:
https://lore.kernel.org/r/6959a6a51582e8bc2343824d0cee56f1db246e23.1655797997.git.pabeni@redhat.com
Thanks.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2022-06-21 13:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-21 13:12 Zheng Bin
2022-06-21 13:29 ` Russell King (Oracle) [this message]
2022-06-21 13:34 ` Paolo Abeni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YrHHyZNJXVme1JIe@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=andrew@lunn.ch \
--cc=boon.leong.ong@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gaochao49@huawei.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=zhengbin13@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®