From: Petr Mladek <pmladek@suse.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Sergey Senozhatsky <senozhatsky@chromium.org>,
Steven Rostedt <rostedt@goodmis.org>,
John Ogness <john.ogness@linutronix.de>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Rasmus Villemoes <linux@rasmusvillemoes.dk>,
Jan Kara <jack@suse.cz>, Peter Zijlstra <peterz@infradead.org>,
"Paul E. McKenney" <paulmck@kernel.org>,
linux-kernel@vger.kernel.org
Subject: [GIT PULL] printk fixups for 5.19-rc4
Date: Thu, 23 Jun 2022 22:23:42 +0200 [thread overview]
Message-ID: <YrTLziUjfxDP/34M@alley> (raw)
Hi Linus,
please pull the revert of printk console kthreads from
git://git.kernel.org/pub/scm/linux/kernel/git/printk/linux.git tags/printk-for-5.19-rc4
We, printk maintainers, really appreciate that you gave us
the chance to try the console kthreads in 5.19 release candidates.
We expected some problems and were able so solve them. But
the missing synchronization between early and normal consoles
made us nervous. We would like to review all console drivers and
look for this kind of expectations that were provided by the original
code.
There are many console drivers and the review will take some time.
We do not want to risk bigger changes late in the release cycle
and problems in the released 5.19. We prefer to revert it now.
Thanks a lot for the chance and sorry for the troubles.
We have new material for improvements.
=========================================
- Revert printk console kthreads. The testing of 5.19 release candidates
revealed issues that did not happen when all consoles were serialized
using the console semaphore. More time is needed to check expectations
of the existing console drivers and be confident that they can
be safely used in parallel.
----------------------------------------------------------------
Petr Mladek (7):
Revert "printk: Wait for the global console lock when the system is going down"
Revert "printk: Block console kthreads when direct printing will be required"
Revert "printk: remove @console_locked"
Revert "printk: extend console_lock for per-console locking"
Revert "printk: add kthread console printers"
Revert "printk: add functions to prefer direct printing"
Merge branch 'rework/kthreads' into for-linus
drivers/tty/sysrq.c | 2 -
include/linux/console.h | 17 --
include/linux/printk.h | 16 --
kernel/hung_task.c | 11 +-
kernel/panic.c | 6 -
kernel/printk/internal.h | 2 -
kernel/printk/printk.c | 593 +++++---------------------------------------
kernel/printk/printk_safe.c | 32 ---
kernel/rcu/tree_stall.h | 2 -
kernel/reboot.c | 16 +-
kernel/watchdog.c | 4 -
kernel/watchdog_hld.c | 4 -
12 files changed, 65 insertions(+), 640 deletions(-)
next reply other threads:[~2022-06-23 20:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-23 20:23 Petr Mladek [this message]
2022-06-24 18:44 ` pr-tracker-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YrTLziUjfxDP/34M@alley \
--to=pmladek@suse.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=jack@suse.cz \
--cc=john.ogness@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=paulmck@kernel.org \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=senozhatsky@chromium.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®