From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3934AC43334 for ; Fri, 24 Jun 2022 11:45:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231630AbiFXLo6 (ORCPT ); Fri, 24 Jun 2022 07:44:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36598 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231545AbiFXLou (ORCPT ); Fri, 24 Jun 2022 07:44:50 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3A6F17A6FC for ; Fri, 24 Jun 2022 04:44:50 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id EB8EBB82863 for ; Fri, 24 Jun 2022 11:44:48 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 420AAC34114; Fri, 24 Jun 2022 11:44:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1656071087; bh=qxPeo/Nw6Qd0O6UxjAzSWKbn3EkYBlOSQmLxfp1xVqU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=0EwM7Uv0+2NcfGDCx1hqjO6z98pnx8FCDHV3bgx5T17byHhpPBRq00eBcgVRJoQC7 +YbA33Gp83lbi6JLVzcp5DgOzAuRzplv8KQcHMqd46ynPIjmuL3TfFUFnxGlLgqp3i 9W6eW8TNA19GFYIdNRpuAhYfmy9ah2nD0odehepQ= Date: Fri, 24 Jun 2022 13:32:03 +0200 From: Greg Kroah-Hartman To: Felix Schlepper Cc: Dan Carpenter , Andy Shevchenko , linux-staging@lists.linux.dev, Linux Kernel Mailing List Subject: Re: [PATCH v4 3/3] Staging: rtl8192e: Cleaning up error handling Message-ID: References: <13b32131cd00a1f0b8793657a24ada71240a8350.1655975970.git.f3sch.git@outlook.com> <20220624052118.GT16517@kadam> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 24, 2022 at 10:41:42AM +0200, Felix Schlepper wrote: > On 24.06.2022 08:21, Dan Carpenter wrote: > > On Thu, Jun 23, 2022 at 11:20:49PM +0200, Andy Shevchenko wrote: > > > On Thu, Jun 23, 2022 at 10:44 PM Felix Schlepper wrote: > > > > > > > > Moved error handling to one common block. > > > > This removes double checking if all txb->fragments[] > > > > were initialized. > > > > The original code worked fine, but this is cleaner. > > > > > > ... > > > > > > > +err_free: > > > > + while (--i >= 0) > > > > > > while (i--) > > > > > > will suffice. > > > > > > > Either one is fine. You prefer this format. I prefer that other > > format. I told Felix he could use either format without expressing any > > bias and he chose my format. That means he loves me more. > > > > regards, > > dan carpenter > Andy's advice is of course much appreciated but I prefer Dan's style <3. > > On another note, the thread is quite messy now, since all my previous > failed attempts to send are now threaded to this one. > How would I go about solving this? Sending another v5 version, the v4 > with [RESEND PATCH v4...] or does this even need any action on my part? Please resend a v5, as I now have 3 different copies of a v4 series in my inbox, which makes no sense at all. Remember, make it obvious as to what to do for those of us who have to handle 1000+ emails a day... thanks, greg k-h