From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F3126C43334 for ; Fri, 24 Jun 2022 14:53:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233470AbiFXOxG (ORCPT ); Fri, 24 Jun 2022 10:53:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57132 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233695AbiFXOwh (ORCPT ); Fri, 24 Jun 2022 10:52:37 -0400 Received: from relay9-d.mail.gandi.net (relay9-d.mail.gandi.net [IPv6:2001:4b98:dc4:8::229]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 563257B34A for ; Fri, 24 Jun 2022 07:47:46 -0700 (PDT) Received: (Authenticated sender: paul.kocialkowski@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 49D69FF804; Fri, 24 Jun 2022 14:47:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1656082064; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=/5lwqCmDfgarZpH/+DYuV1w1W6dB+x06YFC1AxqeVeQ=; b=ImWs1iP8fokVxeUbt87bRF+OpaoNKFG4ZCK343vscEwvalHP0g+xEN51LoEhVAZ1PTSFvO VQdbjHIXr4M98i9fhYcm18+jJrK1a9u6zcguc82LsgnF6udGbo846xG1Rr1vRuqt4/O1ID U3hKwYisqZBvXktP4Ke+CoorBdJWLtfE3ZOZMsoBxR3GspQwcWjTBbomyBiOak8ZTKFg50 G2FoZP3xuqVYC6EydseE6elbSZDzS4wj79gSto5V3JwGB1xMVUeaS5vKalp5wqqfe68ye9 19qXIDdilD21diuZFQhc8pO+N6FiVvMpAGk3lyLGGLiQxouDDA64I0kf+va60w== Date: Fri, 24 Jun 2022 16:47:43 +0200 From: Paul Kocialkowski To: Yang Yingliang Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, airlied@linux.ie, daniel@ffwll.ch, mripard@kernel.org Subject: Re: [PATCH -next] drm/logicvc: Fix error return code in logicvc_layer_init() Message-ID: References: <20220623140507.626062-1-yangyingliang@huawei.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="HhRDR0/yj0N7IbgY" Content-Disposition: inline In-Reply-To: <20220623140507.626062-1-yangyingliang@huawei.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --HhRDR0/yj0N7IbgY Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Yang, On Thu 23 Jun 22, 22:05, Yang Yingliang wrote: > Fix error return code when logicvc_layer_formats_lookup() fails. >=20 > Fixes: efeeaefe9be5 ("drm: Add support for the LogiCVC display controller= ") > Reported-by: Hulk Robot > Signed-off-by: Yang Yingliang Good catch! Yet Dan submitted a similar fix earlier, which is already on its way to the tree. Thanks! Paul > --- > drivers/gpu/drm/logicvc/logicvc_layer.c | 1 + > 1 file changed, 1 insertion(+) >=20 > diff --git a/drivers/gpu/drm/logicvc/logicvc_layer.c b/drivers/gpu/drm/lo= gicvc/logicvc_layer.c > index fbebe966f93a..54b5931d879f 100644 > --- a/drivers/gpu/drm/logicvc/logicvc_layer.c > +++ b/drivers/gpu/drm/logicvc/logicvc_layer.c > @@ -489,6 +489,7 @@ static int logicvc_layer_init(struct logicvc_drm *log= icvc, > =20 > formats =3D logicvc_layer_formats_lookup(layer); > if (!formats) { > + ret =3D -EINVAL; > drm_err(drm_dev, "Failed to lookup formats for layer #%d\n", > index); > goto error; > --=20 > 2.25.1 >=20 --=20 Paul Kocialkowski, Bootlin Embedded Linux and kernel engineering https://bootlin.com --HhRDR0/yj0N7IbgY Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEJZpWjZeIetVBefti3cLmz3+fv9EFAmK1zo8ACgkQ3cLmz3+f v9Hauwf/Sr5lfkjLYZPyt+DqT+dWh/4eDCQP939k7QgLZ1fRsHbgu8HE3n48p6qy yhYLpb4/hhL7F3W7dtYEPgbM9OmDts34GycSqQFjnkH18BhMbKTV9p+ZnVeFtALb CzYGK6gkBekzIlqmyOeOF9MdigEQJMA57WvbdTHvUCZWGaQX+HGqFbm8hRUX60To +uK0ByhM94zYW3/m9R6dzf8ysr4kCJIr33VhH7hf6/ORk3Rr9H2+z86C/4V6/NIs zzCzlUHem9ff5UoqghlCqm/543eHSFO5LsRQ0UA86OW/kbmYL1QLYHT4KC60OPZb 9eriFOQwlKbTSnU81IxK5tkZ6LUnZA== =J0ua -----END PGP SIGNATURE----- --HhRDR0/yj0N7IbgY--