From: Yury Norov <yury.norov@gmail.com>
To: Qu Wenruo <wqu@suse.com>
Cc: linux-kernel@vger.kernel.org, andriy.shevchenko@linux.intel.com,
linux@rasmusvillemoes.dk
Subject: Re: [PATCH] lib: bitmap: fix the duplicated comments on bitmap_to_arr64()
Date: Fri, 24 Jun 2022 08:10:38 -0700 [thread overview]
Message-ID: <YrXT7j62m9MjF93K@yury-laptop> (raw)
In-Reply-To: <0d85e1dbad52ad7fb5787c4432bdb36cbd24f632.1656063005.git.wqu@suse.com>
On Fri, Jun 24, 2022 at 05:31:47PM +0800, Qu Wenruo wrote:
> Thanks to the recent commit 0a97953fd221 ("lib: add
> bitmap_{from,to}_arr64") now we can directly convert a U64 value into a
> bitmap and vice verse.
>
> However when checking the header there is duplicated helper for
> bitmap_to_arr64(), but no bitmap_from_arr64().
>
> Just fix the copy-n-paste error.
I spotted it as well, but you're the first. :-) Thanks.
Applied in bitmap-for-next.
> Signed-off-by: Qu Wenruo <wqu@suse.com>
> ---
> include/linux/bitmap.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/bitmap.h b/include/linux/bitmap.h
> index 2e6cd5681040..f091a1664bf1 100644
> --- a/include/linux/bitmap.h
> +++ b/include/linux/bitmap.h
> @@ -71,9 +71,9 @@ struct device;
> * bitmap_release_region(bitmap, pos, order) Free specified bit region
> * bitmap_allocate_region(bitmap, pos, order) Allocate specified bit region
> * bitmap_from_arr32(dst, buf, nbits) Copy nbits from u32[] buf to dst
> + * bitmap_from_arr64(dst, buf, nbits) Copy nbits from u64[] buf to dst
> * bitmap_to_arr32(buf, src, nbits) Copy nbits from buf to u32[] dst
> * bitmap_to_arr64(buf, src, nbits) Copy nbits from buf to u64[] dst
> - * bitmap_to_arr64(buf, src, nbits) Copy nbits from buf to u64[] dst
> * bitmap_get_value8(map, start) Get 8bit value from map at start
> * bitmap_set_value8(map, value, start) Set 8bit value to map at start
> *
> --
> 2.36.1
prev parent reply other threads:[~2022-06-24 15:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-24 9:31 Qu Wenruo
2022-06-24 15:10 ` Yury Norov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YrXT7j62m9MjF93K@yury-laptop \
--to=yury.norov@gmail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®