From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F7D7C43334 for ; Fri, 24 Jun 2022 19:40:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230475AbiFXTkv (ORCPT ); Fri, 24 Jun 2022 15:40:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34608 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229645AbiFXTku (ORCPT ); Fri, 24 Jun 2022 15:40:50 -0400 Received: from mailrelay1-1.pub.mailoutpod1-cph3.one.com (mailrelay1-1.pub.mailoutpod1-cph3.one.com [46.30.210.182]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 42D0A823BD for ; Fri, 24 Jun 2022 12:40:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ravnborg.org; s=rsa1; h=in-reply-to:content-type:mime-version:references:message-id:subject:cc:to: from:date:from; bh=Ad+DhE3IbR2iex/yzIihLX8YVyGXpjxJ1bB/wP9flSI=; b=mytJqSGFcuARUCabX8nUTEB/63IYrkijltDqr6UmmHvKrxZ9w44lUTPvkutRRZleY7JX9dHMVTBzO xfzQ3HKpGMUL8EDCjwY0/iFTf8rNPqV4kJcGEiypUxGpexBZF90ic6klsxM3I+rfbKYwecIYTLUJno ggtNWD1np/PoeZv48NfpW3mdKYCWg6ZReiWn5cIGGVDuyZCOOITQVuzCJa7dnkFltzV1Ak7dO4KNWh oLQWZCkqPqDVD+Gbinx/r83gD7NMdQq0ZY6XHrZcFmdmUwB90Zzo+0NIBw9GbACmRUYvZ8OKc8CRL2 w4LU4YaYf3nPI32LawHlnqgyK96wmUw== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=ravnborg.org; s=ed1; h=in-reply-to:content-type:mime-version:references:message-id:subject:cc:to: from:date:from; bh=Ad+DhE3IbR2iex/yzIihLX8YVyGXpjxJ1bB/wP9flSI=; b=rR+tHXGotv42P7yrodke39gH5FV4pav+ErgJmaVngNqdZ1iIOVUbe5MgOgl6gpeguV06GZemdMnpK pJvNDIgCQ== X-HalOne-Cookie: f849e6918b8cd146939bcb738a198ec6a476cb6a X-HalOne-ID: 8b496d47-f3f5-11ec-a6c4-d0431ea8a283 Received: from mailproxy2.cst.dirpod3-cph3.one.com (80-162-45-141-cable.dk.customer.tdc.net [80.162.45.141]) by mailrelay1.pub.mailoutpod1-cph3.one.com (Halon) with ESMTPSA id 8b496d47-f3f5-11ec-a6c4-d0431ea8a283; Fri, 24 Jun 2022 19:40:47 +0000 (UTC) Date: Fri, 24 Jun 2022 21:40:45 +0200 From: Sam Ravnborg To: Stephen Kitt Cc: Thierry Reding , Daniel Thompson , David Airlie , Sebastian Reichel , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/3] drm/panel: Use backlight helper Message-ID: References: <20220616172316.1355133-2-steve@sk2.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220616172316.1355133-2-steve@sk2.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 16, 2022 at 07:23:13PM +0200, Stephen Kitt wrote: > backlight_properties.fb_blank is deprecated. The states it represents > are handled by other properties; but instead of accessing those > properties directly, drivers should use the helpers provided by > backlight.h. > > Instead of retrieving the backlight brightness in struct > backlight_properties manually, and then checking whether the backlight > should be on at all, use backlight_get_brightness() which does all > this and insulates this from future changes. > > Signed-off-by: Stephen Kitt > Cc: Thierry Reding > Cc: Sam Ravnborg > Cc: David Airlie > Cc: Daniel Vetter > Cc: dri-devel@lists.freedesktop.org Thanks, applied to drm-misc (drm-misc-next) Sam