From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C8DF8C43334 for ; Fri, 24 Jun 2022 20:00:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231437AbiFXUAR (ORCPT ); Fri, 24 Jun 2022 16:00:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49964 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229441AbiFXUAQ (ORCPT ); Fri, 24 Jun 2022 16:00:16 -0400 Received: from mailrelay4-1.pub.mailoutpod1-cph3.one.com (mailrelay4-1.pub.mailoutpod1-cph3.one.com [46.30.210.185]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D957882680 for ; Fri, 24 Jun 2022 13:00:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ravnborg.org; s=rsa1; h=in-reply-to:content-type:mime-version:references:message-id:subject:cc:to: from:date:from; bh=hEGNVGl+SZAARGmSdNCweniFlHwABQxHwPZBDjq6yRA=; b=JLLEI6ujyiAG3rp3H7xyLxcYlGJ/hVLLREa1VgsJE8xHDdvmm+Iife+Nbt/zQPlwx/H4iM6uWAKVe wDq4IbRtLMNB0uywL0gx+xeWMCGZoXK7QjfheGvH7KjYq/rZqPooQoyZRXmNnqaYDX+udBaoWQgJ6l fDnQ8p6KsXzpnLyo17Ih/28E7dkiT2lflfZhaVpcuVj13DUIUQSiVS1k/iA2PbN/07PcRJ8ZGtJ3Zn aQaz0M5ujKiLK8ekyngWDhj0YtUVpzKdZGbnlQCv74guMkiSiOdzCwz1kt7qa5MYtDSKrQn3n96RNA K/iD+EKV93MY2O0tod78jr/ww3rQlBQ== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=ravnborg.org; s=ed1; h=in-reply-to:content-type:mime-version:references:message-id:subject:cc:to: from:date:from; bh=hEGNVGl+SZAARGmSdNCweniFlHwABQxHwPZBDjq6yRA=; b=N/OQDvIb5H+8xT6dShXqQLCs9XlMGb8LNYHSwiX5IRt+1RJg4qnFf8gZ77AiODkC1ZM6bCVi7V8or DwipM+MBg== X-HalOne-Cookie: 03ce154afd92931682423ec165f1f06fae96aef2 X-HalOne-ID: 42830791-f3f8-11ec-8233-d0431ea8bb10 Received: from mailproxy2.cst.dirpod3-cph3.one.com (80-162-45-141-cable.dk.customer.tdc.net [80.162.45.141]) by mailrelay4.pub.mailoutpod1-cph3.one.com (Halon) with ESMTPSA id 42830791-f3f8-11ec-8233-d0431ea8bb10; Fri, 24 Jun 2022 20:00:13 +0000 (UTC) Date: Fri, 24 Jun 2022 22:00:12 +0200 From: Sam Ravnborg To: Stephen Kitt Cc: Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , David Airlie , Daniel Vetter , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH] drm/bridge: parade-ps8622: Use backlight helper Message-ID: References: <20220607181022.1119546-1-steve@sk2.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220607181022.1119546-1-steve@sk2.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 07, 2022 at 08:10:22PM +0200, Stephen Kitt wrote: > backlight_properties.fb_blank is deprecated. The states it represents > are handled by other properties; but instead of accessing those > properties directly, drivers should use the helpers provided by > backlight.h. > > Instead of retrieving the backlight brightness in struct > backlight_properties manually, and then checking whether the backlight > should be on at all, use backlight_get_brightness() which does all > this and insulates this from future changes. > > Signed-off-by: Stephen Kitt > Cc: Andrzej Hajda > Cc: Neil Armstrong > Cc: Robert Foss > Cc: Laurent Pinchart > Cc: Jonas Karlman > Cc: Jernej Skrabec > Cc: David Airlie > Cc: Daniel Vetter > Cc: dri-devel@lists.freedesktop.org Thanks, applied to drm-misc (drm-misc-next). I kept the full changelog. Sam