mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Herbert Xu <herbert@gondor.apana.org.au>
To: Vladis Dronov <vdronov@redhat.com>
Cc: "David S . Miller" <davem@davemloft.net>,
	Randy Dunlap <rdunlap@infradead.org>,
	linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org,
	Simo Sorce <simo@redhat.com>
Subject: Re: [PATCH v2] crypto: fips - make proc files report fips module name and version
Date: Mon, 27 Jun 2022 09:19:04 +0800	[thread overview]
Message-ID: <YrkFiM+Y2G7a50z5@gondor.apana.org.au> (raw)
In-Reply-To: <20220621150832.1710738-1-vdronov@redhat.com>

On Tue, Jun 21, 2022 at 05:08:32PM +0200, Vladis Dronov wrote:
>
> diff --git a/include/linux/fips.h b/include/linux/fips.h
> index c6961e932fef..72d2e0e1d3ac 100644
> --- a/include/linux/fips.h
> +++ b/include/linux/fips.h
> @@ -2,10 +2,19 @@
>  #ifndef _FIPS_H
>  #define _FIPS_H
>  
> +#include <generated/utsrelease.h>
> +
>  #ifdef CONFIG_CRYPTO_FIPS
>  extern int fips_enabled;
>  extern struct atomic_notifier_head fips_fail_notif_chain;
>  
> +#define FIPS_MODULE_NAME CONFIG_CRYPTO_FIPS_NAME
> +#ifdef CONFIG_CRYPTO_FIPS_CUSTOM_VERSION
> +#define FIPS_MODULE_VERSION CONFIG_CRYPTO_FIPS_VERSION
> +#else
> +#define FIPS_MODULE_VERSION UTS_RELEASE
> +#endif

Why does this need to be in fips.h? If it's only used by one file
then it should be moved to the place where it's used.

Thanks,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

  reply	other threads:[~2022-06-27  1:19 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-20 13:16 [PATCH] " Vladis Dronov
2022-06-20 21:15 ` Randy Dunlap
2022-06-21 14:35   ` Vlad Dronov
2022-06-21 15:08 ` [PATCH v2] " Vladis Dronov
2022-06-27  1:19   ` Herbert Xu [this message]
2022-06-27 19:50     ` Vlad Dronov
2022-06-27 19:51 ` [PATCH v3] " Vladis Dronov
2022-07-08  7:20   ` Herbert Xu
2022-07-08 12:46     ` Vlad Dronov
2022-07-08 12:33 ` [PATCH v4] " Vladis Dronov
2022-07-15  8:49   ` Herbert Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YrkFiM+Y2G7a50z5@gondor.apana.org.au \
    --to=herbert@gondor.apana.org.au \
    --cc=davem@davemloft.net \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rdunlap@infradead.org \
    --cc=simo@redhat.com \
    --cc=vdronov@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®