From: Herbert Xu <herbert@gondor.apana.org.au>
To: "Jason A. Donenfeld" <Jason@zx2c4.com>
Cc: "Gregory Erwin" <gregerwin256@gmail.com>,
"Toke Høiland-Jørgensen" <toke@redhat.com>,
linux-wireless <linux-wireless@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
"Kalle Valo" <kvalo@kernel.org>,
"Rui Salvaterra" <rsalvaterra@gmail.com>,
stable <stable@vger.kernel.org>
Subject: Re: [PATCH v6] ath9k: sleep for less time when unregistering hwrng
Date: Tue, 28 Jun 2022 18:51:57 +0800 [thread overview]
Message-ID: <YrrdTcRCKBt15HLz@gondor.apana.org.au> (raw)
In-Reply-To: <CAHmME9prgW60P+CO1JSdf5o1hBh8JtciBxcYm25ZO6oTCkwkxg@mail.gmail.com>
On Tue, Jun 28, 2022 at 12:48:50PM +0200, Jason A. Donenfeld wrote:
>
> $ curl https://lore.kernel.org/lkml/20220627104955.534013-1-Jason@zx2c4.com/raw
> | git am
>
> That one, if you want to give it a spin and see if that 5-6s is back
> to ~1s or less.
Whatever caused kthread_should_stop to return true should have
woken the thread and caused schedule_timeout to return.
If it's not waking the thread up then we should find out why.
Oh wait you're checking kthread_should_stop before the schedule
call instead of afterwards, that would do it.
Cheers,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2022-06-28 10:52 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <YrUKUt5nvX8qf1Je@zx2c4.com>
2022-06-24 1:14 ` [PATCH] ath9k: rng: escape sleep loop when unregistering Jason A. Donenfeld
2022-06-24 5:25 ` Gregory Erwin
2022-06-24 19:12 ` Jason A. Donenfeld
2022-06-24 20:44 ` [PATCH v2] ath9k: sleep for less time when unregistering hwrng Jason A. Donenfeld
2022-06-25 0:13 ` Gregory Erwin
2022-06-25 0:40 ` Jason A. Donenfeld
2022-06-27 6:45 ` Herbert Xu
2022-06-27 9:29 ` [PATCH v3] " Jason A. Donenfeld
2022-06-27 10:49 ` [PATCH v4] " Jason A. Donenfeld
2022-06-27 11:37 ` [PATCH v5] " Jason A. Donenfeld
2022-06-27 12:07 ` [PATCH v6] " Jason A. Donenfeld
2022-06-27 12:18 ` Toke Høiland-Jørgensen
2022-06-28 1:39 ` Gregory Erwin
2022-06-28 10:46 ` Jason A. Donenfeld
2022-06-28 10:48 ` Jason A. Donenfeld
2022-06-28 10:51 ` Herbert Xu [this message]
2022-06-28 10:55 ` Jason A. Donenfeld
2022-06-28 12:05 ` Jason A. Donenfeld
2022-06-28 15:14 ` Jason A. Donenfeld
2022-06-28 1:53 ` Herbert Xu
2022-06-28 10:45 ` Toke Høiland-Jørgensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YrrdTcRCKBt15HLz@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=Jason@zx2c4.com \
--cc=gregerwin256@gmail.com \
--cc=kvalo@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=rsalvaterra@gmail.com \
--cc=stable@vger.kernel.org \
--cc=toke@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®