From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8888BCCA480 for ; Thu, 14 Jul 2022 10:07:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238074AbiGNKHV (ORCPT ); Thu, 14 Jul 2022 06:07:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47028 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238047AbiGNKHQ (ORCPT ); Thu, 14 Jul 2022 06:07:16 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3DC0F51406; Thu, 14 Jul 2022 03:07:15 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id CDCDD61FC7; Thu, 14 Jul 2022 10:07:14 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 32832C34114; Thu, 14 Jul 2022 10:07:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1657793234; bh=bSKkH2jvKSAI3EiQUqhslwIC6F4g+v4LiBs8ZL7Da80=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=POcam2qFW9ucCQKozq6eRb7dLksw5QSsF4HPhST5L9cJchZbGVS8pZhrB+OFfFgg6 va14SjilQwkXkHBRd0ETpPGywkoc1wW1bhF3SoFMUvAhv/hOyDfnOl5b3+hE/EZSA6 vOTOZ4TCW5mSGa01x0fc6FZWZtDWq3B25oI2njoolmQMgGu6hu3EQWPawXK+beKJDF XExxqSBY0jyixrLSyEW1rNP488WG/wOjifSRX6/CVfmyNZkapZcFYXTxJ7ONkBps7v yAx7LBSlwdHWDLnRkKW/Z7mgSmvef8DxJEEeDMyJnKzjXX2IWLgj6udaTPoCmhkReU xNLfgaBbO5HGw== Received: from johan by xi.lan with local (Exim 4.94.2) (envelope-from ) id 1oBvkb-0008Qr-Uv; Thu, 14 Jul 2022 12:07:18 +0200 Date: Thu, 14 Jul 2022 12:07:17 +0200 From: Johan Hovold To: Krzysztof Kozlowski Cc: Johan Hovold , Vinod Koul , Rob Herring , Krzysztof Kozlowski , Dmitry Baryshkov , Andy Gross , Bjorn Andersson , Kishon Vijay Abraham I , linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 16/30] dt-bindings: phy: qcom,qmp-ufs: add missing SM8450 clock Message-ID: References: <20220707134725.3512-1-johan+linaro@kernel.org> <20220707134725.3512-17-johan+linaro@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 14, 2022 at 11:21:52AM +0200, Krzysztof Kozlowski wrote: > On 07/07/2022 15:47, Johan Hovold wrote: > > Add the missing "qref" clock used by the SM8450 UFS QMP PHY to the > > binding. > > > > Fixes: e04121ba1b08 ("dt-bindings: phy: qcom,qmp: Add SM8450 UFS phy compatible") > > Fixes: 07fa917a335e ("arm64: dts: qcom: sm8450: add ufs nodes") > > The second fixes seems not appropriate here, because you are not fixing > a DTS. A fix for DTS would be a fix for that one. I wanted to highlight the fact the binding wasn't amended when the DTS started using the new clock, which it should have. But sure, that would have gone in a separate patch. I can replace the second Fixes with a Link to the dts submission as a reference instead. Johan