From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 199C4C43334 for ; Wed, 13 Jul 2022 15:24:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236509AbiGMPYK (ORCPT ); Wed, 13 Jul 2022 11:24:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60240 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236926AbiGMPYH (ORCPT ); Wed, 13 Jul 2022 11:24:07 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C95DA15FE6; Wed, 13 Jul 2022 08:24:06 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 4A8DBB8204D; Wed, 13 Jul 2022 15:24:05 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7933CC34114; Wed, 13 Jul 2022 15:24:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1657725844; bh=h53LTrPedEhY3bM9vbncNkqrULxJF3EKAjvif3liSIo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=YxmhN0pRnl9WaNV5CLQ5t0k/TNk3+cql6b8DvJ0RfJoKe2WC9GGwHJfP61VLirhEp t6SkxwMmYzLmPXlVX388oVj40hlcYnhOj48PCO3Cb+8wqH4+t/fh0uAf+diNrxod8l 7jp1sENMPqV1wiVvQBwvMwXj0QNFF5JbNJA6Hz9oEcvtZdDqOI4wRvWXpi2gX63iGt Alf2EGSgE0AvLSGMqH3w2kTKBWDMjocGuea/x/JVwrBwhRpAo0qyxhU9PW1Z/0pfgx GVGsdhHc2xDBl8heg9x94IrKIEW5BPj1W7zh48LqEsMq7isZx3EO3ZwM0iOIHQm02n WNOsvB4K9Nwpg== Date: Wed, 13 Jul 2022 08:24:01 -0700 From: Nathan Chancellor To: Linus Torvalds , x86@kernel.org Cc: Nick Desaulniers , Peter Zijlstra , Josh Poimboeuf , linux-kernel@vger.kernel.org, llvm@lists.linux.dev, stable@vger.kernel.org, kernel test robot Subject: Re: [PATCH] x86/speculation: Use DECLARE_PER_CPU for x86_spec_ctrl_current Message-ID: References: <20220713152222.1697913-1-nathan@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220713152222.1697913-1-nathan@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 13, 2022 at 08:22:22AM -0700, Nathan Chancellor wrote: > Clang warns: > > arch/x86/kernel/cpu/bugs.c:58:21: error: section attribute is specified on redeclared variable [-Werror,-Wsection] > DEFINE_PER_CPU(u64, x86_spec_ctrl_current); > ^ > arch/x86/include/asm/nospec-branch.h:283:12: note: previous declaration is here > extern u64 x86_spec_ctrl_current; > ^ > 1 error generated. > > The declaration should be using DECLARE_PER_CPU instead so all > attributes stay in sync. > > Cc: stable@vger.kernel.org > Fixes: fc02735b14ff ("KVM: VMX: Prevent guest RSB poisoning attacks with eIBRS") > Reported-by: kernel test robot > Signed-off-by: Nathan Chancellor > --- > arch/x86/include/asm/nospec-branch.h | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/arch/x86/include/asm/nospec-branch.h b/arch/x86/include/asm/nospec-branch.h > index bb05ed4f46bd..99a29c83adf8 100644 > --- a/arch/x86/include/asm/nospec-branch.h > +++ b/arch/x86/include/asm/nospec-branch.h > @@ -6,6 +6,7 @@ > #include > #include > #include > +#include Argh, forgot to amend... v2 incoming. > #include > #include > @@ -280,7 +281,7 @@ static inline void indirect_branch_prediction_barrier(void) > > /* The Intel SPEC CTRL MSR base value cache */ > extern u64 x86_spec_ctrl_base; > -extern u64 x86_spec_ctrl_current; > +DECLARE_PER_CPU(u64, x86_spec_ctrl_current); > extern void write_spec_ctrl_current(u64 val, bool force); > extern u64 spec_ctrl_current(void); > > > base-commit: 72a8e05d4f66b5af7854df4490e3135168694b6b > -- > 2.37.1 >