From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9DBA4CCA481 for ; Wed, 13 Jul 2022 15:36:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237013AbiGMPgN (ORCPT ); Wed, 13 Jul 2022 11:36:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42638 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236991AbiGMPgH (ORCPT ); Wed, 13 Jul 2022 11:36:07 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3261F4E845; Wed, 13 Jul 2022 08:36:01 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id D3F83B8204D; Wed, 13 Jul 2022 15:35:59 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4F184C34114; Wed, 13 Jul 2022 15:35:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1657726558; bh=mgxy9tQlFOmuXGe/eDtjY4cNpf4Y+AzDQIzHZ79WdcU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=pYuTs0tk2wj9krwWwVU7XAoM7TqSndfIBr601D0J36JHSuzoIsmSftnD3LfBN6j5f CYyX76ZU0MrLKgJD/zO+5IhBxFj7Ecl2Nv56vs33nbQsSofTebQ0St3dfQAy2/JxL6 RpzqIQIwIHqfOlPztwzTmSGZW4F4OGi0ri2DGtJ0= Date: Wed, 13 Jul 2022 17:35:54 +0200 From: Greg Kroah-Hartman To: Dario Binacchi Cc: linux-kernel@vger.kernel.org, Richard Palethorpe , Jeroen Hofstee , Linux Memory Management List , kernel test robot , lkp@intel.com, lkp@lists.01.org, ltp@lists.linux.it, "David S. Miller" , Eric Dumazet , Jakub Kicinski , Jiri Slaby , Marc Kleine-Budde , Paolo Abeni , Sebastian Andrzej Siewior , Vincent Mailhol , Wolfgang Grandegger , linux-can@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH] can: slcan: do not sleep with a spin lock held Message-ID: References: <20220713151947.56379-1-dario.binacchi@amarulasolutions.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220713151947.56379-1-dario.binacchi@amarulasolutions.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 13, 2022 at 05:19:47PM +0200, Dario Binacchi wrote: > We can't call close_candev() with a spin lock held, so release the lock > before calling it. > > Fixes: c4e54b063f42f ("can: slcan: use CAN network device driver API") > Reported-by: kernel test robot > Link: https://lore.kernel.org/linux-kernel/Ysrf1Yc5DaRGN1WE@xsang-OptiPlex-9020/ > Signed-off-by: Dario Binacchi > > --- > > drivers/net/can/slcan/slcan-core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/can/slcan/slcan-core.c b/drivers/net/can/slcan/slcan-core.c > index 54d29a410ad5..6aaf2986effc 100644 > --- a/drivers/net/can/slcan/slcan-core.c > +++ b/drivers/net/can/slcan/slcan-core.c > @@ -688,6 +688,7 @@ static int slc_close(struct net_device *dev) > /* TTY discipline is running. */ > clear_bit(TTY_DO_WRITE_WAKEUP, &sl->tty->flags); > } > + spin_unlock_bh(&sl->lock); > netif_stop_queue(dev); Can you have a lock held when calling netif_stop_queue()? You don't mention this in your changelog text :( thanks, greg k-h