From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B716C433EF for ; Thu, 7 Jul 2022 04:42:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234748AbiGGEmx (ORCPT ); Thu, 7 Jul 2022 00:42:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52398 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229553AbiGGEmr (ORCPT ); Thu, 7 Jul 2022 00:42:47 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 25A322F037; Wed, 6 Jul 2022 21:42:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=AbIgiz4HdWTHJrDcwgiMjNLozJ+fa1Um61VNXrTWXuw=; b=JLXuMSRapJzauQSgyJpNyTpYAj FHX1E3ZNecpiiGROvvfEp8SwwbAs3xM7y7Gtww8T317u7YSPOLnT7Om54pv+VxZCzOcBD9Wf617/U yOM3KkO/FIEZ72d73h5KUdTJADuM8/wuU5dGtUEIr5/LNK4TbRZbdy1IB+ApOtViLobIewkOar6fx R3cwAKogG84EkVmlNXr2awmyI///KOGitJJfgjGOjUVyoRiDbY1Blylwee9XOgx/Ql13EuncLaMeN BEww+BEZ9E4q+i0/JKMTPE9dGNbmok0FTBvCd/LTdoUoZvgdVi9X+x9JeWzH7MYTDSb8xYIOZYUSB ZG3eBhbw==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1o9JLc-00DW1r-FB; Thu, 07 Jul 2022 04:42:40 +0000 Date: Wed, 6 Jul 2022 21:42:40 -0700 From: Christoph Hellwig To: Konstantin Komarov Cc: ntfs3@lists.linux.dev, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH 0/2] fs/ntfs3: Refactoring and improving logic in run_pack Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Konstantin, now that you have time to actively work on the ntfs3 driver again, can you consider looking into converting the I/O path to iomap, as already request during the merge? Getting drivers off the old buffer head based I/O helpers is something we need to address in the coming years, so any relatively simple and actually maintained file system would be a good start. On Wed, Jul 06, 2022 at 08:31:25PM +0300, Konstantin Komarov wrote: > 2 patches: > - some comments and making function static; > - improving speed of run_pack by checking runs in advance > > Konstantin Komarov (2): > fs/ntfs3: Added comments to frecord functions > fs/ntfs3: Check possible errors in run_pack in advance > > fs/ntfs3/bitmap.c | 3 +-- > fs/ntfs3/frecord.c | 8 ++++---- > fs/ntfs3/ntfs_fs.h | 1 - > fs/ntfs3/run.c | 41 +++++++++++++++++++++++------------------ > 4 files changed, 28 insertions(+), 25 deletions(-) > > -- > 2.37.0 > ---end quoted text---