From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0D76CC43334 for ; Thu, 7 Jul 2022 16:50:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236356AbiGGQuT (ORCPT ); Thu, 7 Jul 2022 12:50:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58656 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236110AbiGGQuP (ORCPT ); Thu, 7 Jul 2022 12:50:15 -0400 Received: from vps0.lunn.ch (vps0.lunn.ch [185.16.172.187]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 49D202A422; Thu, 7 Jul 2022 09:50:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Transfer-Encoding:Content-Disposition: Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:From: Sender:Reply-To:Subject:Date:Message-ID:To:Cc:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Content-Disposition: In-Reply-To:References; bh=ICKmcbHRvrSyUczplI8Beeso0lINOUsmLC2dkDv7txo=; b=1W XLVkE4BimNam9FMNOjWyPAdSc/dGRpLNZ4NxYgKyHqxkskxphYQ9ZTIuTBlFn8t4LPg3Ot4MlkB65 +qIeMQ5wsdCaoLzzFFJWOMAI1wI5M3iUFe6ZWV8q1OZ+whh2xtALwjZak/wYIbz8cr7oafhgTfDCK yx0yc4ncLG1hx6U=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1o9UhU-009bFU-2G; Thu, 07 Jul 2022 18:50:00 +0200 Date: Thu, 7 Jul 2022 18:50:00 +0200 From: Andrew Lunn To: Marek =?iso-8859-1?Q?Beh=FAn?= Cc: Pali =?iso-8859-1?Q?Roh=E1r?= , Gregory Clement , Sebastian Hesselbarth , Rob Herring , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 00/11] ARM: dts: mvebu: Add definitions for PCIe legacy INTx interrupts Message-ID: References: <20220706183114.30783-1-pali@kernel.org> <20220707163818.620ccb95@dellmb> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220707163818.620ccb95@dellmb> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 07, 2022 at 04:38:18PM +0200, Marek Behún wrote: > On Wed, 6 Jul 2022 22:53:46 +0200 > Andrew Lunn wrote: > > > On Wed, Jul 06, 2022 at 08:31:03PM +0200, Pali Rohár wrote: > > > This patch series add definitions for PCIe legacy INTx interrupts into > > > every DTS file used by the pci-mvebu.c controller driver. > > > > What you fail to explain in the commit message is Why? > > > > Andrew > > Hi Andrew, > > this is required for example in a scenario where a driver requests only > one of the legacy interrupts (INTA). Without this change, the driver > would be notified on events on all 4 (INTA, INTB, INTC, INTD), even if > it requested only one of them. O.K, so please add that to the commit message. Is this purely theoretical, or are there known broken platforms out there? Should a subset of these patches be added to stable? Andrew