Re: [linux-stable-rc:linux-4.19.y 1539/3265] drivers/net/ethernet/xilinx/xilinx_axienet_main.c:283:15: error: implicit declaration of function 'read_poll_timeout'

["gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>]

On Wed, Jul 06, 2022 at 10:42:48PM +0000, Robert Hancock wrote:
> On Wed, 2022-07-06 at 18:43 +0800, kernel test robot wrote:
> > Hi Robert,
> > 
> > FYI, the error/warning still remains.
> > 
> > tree:  
> > https://urldefense.com/v3/__https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git__;!!IOGos0k!nK_4HG5DiIjhDaFvtB2c4HTsoQMg8UHEBJDv6stlGIMButbUtJc42wGH5qXaVC5JIkAwZas4Ne1iIw$
> >   linux-4.19.y
> > head:   b9f174a70c6f609b6132c3a65883b16d552984b8
> > commit: 8b8ad8a7ac24905937c3975b54c4594b93b66ebb [1539/3265] net:
> > axienet: Wait for PhyRstCmplt after core reset
> > config: microblaze-randconfig-r003-20220704
> > (https://urldefense.com/v3/__https://download.01.org/0day-ci/archive/
> > 20220706/202207061830.78pJNuwN-lkp@intel.com/config__;!!IOGos0k!nK_4H
> > G5DiIjhDaFvtB2c4HTsoQMg8UHEBJDv6stlGIMButbUtJc42wGH5qXaVC5JIkAwZatUAT
> > tDaQ$ )
> > compiler: microblaze-linux-gcc (GCC) 11.3.0
> > reproduce (this is a W=1 build):
> >         wget
> > https://urldefense.com/v3/__https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross__;!!IOGos0k!nK_4HG5DiIjhDaFvtB2c4HTsoQMg8UHEBJDv6stlGIMButbUtJc42wGH5qXaVC5JIkAwZautG4jkgg$
> >   -O ~/bin/make.cross
> >         chmod +x ~/bin/make.cross
> >         #
> > https://urldefense.com/v3/__https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git/commit/?id=8b8ad8a7ac24905937c3975b54c4594b93b66ebb__;!!IOGos0k!nK_4HG5DiIjhDaFvtB2c4HTsoQMg8UHEBJDv6stlGIMButbUtJc42wGH5qXaVC5JIkAwZas8R9M_sA$
> >  
> >         git remote add linux-stable-rc
> > https://urldefense.com/v3/__https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git__;!!IOGos0k!nK_4HG5DiIjhDaFvtB2c4HTsoQMg8UHEBJDv6stlGIMButbUtJc42wGH5qXaVC5JIkAwZas4Ne1iIw$
> >  
> >         git fetch --no-tags linux-stable-rc linux-4.19.y
> >         git checkout 8b8ad8a7ac24905937c3975b54c4594b93b66ebb
> >         # save the config file
> >         mkdir build_dir && cp config build_dir/.config
> >         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.3.0
> > make.cross W=1 O=build_dir ARCH=microblaze SHELL=/bin/bash
> > drivers/net/ethernet/xilinx/
> > 
> > If you fix the issue, kindly add following tag where applicable
> > Reported-by: kernel test robot <lkp@intel.com>
> > 
> > All errors (new ones prefixed by >>):
> > 
> >    drivers/net/ethernet/xilinx/xilinx_axienet_main.c: In function
> > 'axienet_dma_bd_init':
> >    drivers/net/ethernet/xilinx/xilinx_axienet_main.c:283:9: error:
> > 'ret' undeclared (first use in this function); did you mean 'net'?
> >      283 |         ret = read_poll_timeout(axienet_ior, value,
> >          |         ^~~
> >          |         net
> >    drivers/net/ethernet/xilinx/xilinx_axienet_main.c:283:9: note:
> > each undeclared identifier is reported only once for each function it
> > appears in
> > > > drivers/net/ethernet/xilinx/xilinx_axienet_main.c:283:15: error:
> > > > implicit declaration of function 'read_poll_timeout' [-
> > > > Werror=implicit-function-declaration]
> >      283 |         ret = read_poll_timeout(axienet_ior, value,
> >          |               ^~~~~~~~~~~~~~~~~
> >    drivers/net/ethernet/xilinx/xilinx_axienet_main.c:283:46: error:
> > 'value' undeclared (first use in this function)
> >      283 |         ret = read_poll_timeout(axienet_ior, value,
> >          |                                              ^~~~~
> >    cc1: some warnings being treated as errors
> > 
> 
> This seems like maybe a bad backport of the listed patch to the 4.19
> stable release?

If so, can you provide a fix for this?

thanks,

greg k-h