From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB2BEC433EF for ; Fri, 8 Jul 2022 10:02:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237755AbiGHKCi (ORCPT ); Fri, 8 Jul 2022 06:02:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47890 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237206AbiGHKCc (ORCPT ); Fri, 8 Jul 2022 06:02:32 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B898D83F18; Fri, 8 Jul 2022 03:02:31 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 3F618B80189; Fri, 8 Jul 2022 10:02:30 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AB020C341C8; Fri, 8 Jul 2022 10:02:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1657274549; bh=A1Pn7b+rfBQZeBp7e/jVDi7zX7D7xGFXanXeP0Lzrzk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=LaTsHNke8x16hs+3ttsYIHFYjSMjeskPKOFoDRHkDWd+INIVdaMxLwG4w+XAOQWz7 7vw1o4p43ZNErBCrCSXp+8p+5688GROJo/jHBa5BdVOiTGqx/oDTInPDL0N8gaFK0S xRyqsTWsuspZWLupEiTcfaDDZ3lblYf23xN60wYc= Date: Fri, 8 Jul 2022 12:02:26 +0200 From: Greg KH To: "yekai(A)" Cc: herbert@gondor.apana.org.au, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, wangzhou1@hisilicon.com Subject: Re: [PATCH v5 2/3] Documentation: add a isolation strategy sysfs node for uacce Message-ID: References: <20220708070820.43958-1-yekai13@huawei.com> <20220708070820.43958-3-yekai13@huawei.com> <9eaebf54-5095-0b02-8a06-f7235e2ba793@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9eaebf54-5095-0b02-8a06-f7235e2ba793@huawei.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 08, 2022 at 05:38:17PM +0800, yekai(A) wrote: > > > On 2022/7/8 15:30, Greg KH wrote: > > On Fri, Jul 08, 2022 at 03:08:19PM +0800, Kai Ye wrote: > > > Update documentation describing sysfs node that could help to > > > configure isolation strategy for users in the user space. And > > > describing sysfs node that could read the device isolated state. > > > > > > Signed-off-by: Kai Ye > > > --- > > > Documentation/ABI/testing/sysfs-driver-uacce | 18 ++++++++++++++++++ > > > 1 file changed, 18 insertions(+) > > > > > > diff --git a/Documentation/ABI/testing/sysfs-driver-uacce b/Documentation/ABI/testing/sysfs-driver-uacce > > > index 08f2591138af..a8056271a963 100644 > > > --- a/Documentation/ABI/testing/sysfs-driver-uacce > > > +++ b/Documentation/ABI/testing/sysfs-driver-uacce > > > @@ -19,6 +19,24 @@ Contact: linux-accelerators@lists.ozlabs.org > > > Description: Available instances left of the device > > > Return -ENODEV if uacce_ops get_available_instances is not provided > > > > > > +What: /sys/class/uacce//isolate_strategy > > > +Date: Jul 2022 > > > +KernelVersion: 5.20 > > > +Contact: linux-accelerators@lists.ozlabs.org > > > +Description: A sysfs node that used to configures the hardware error > > > > This is not a "node" it is just a file. > > > > > > > + isolation strategy. This strategy is a configured integer value. > > > + The default is 0. The maximum value is 65535. This value > > > + indicates the number of device slot resets per unit time > > > + that your service can tolerate. > > > > I do not understand this, sorry. What do you mean by "that your service > > can tolerate"? > > it means the user can tolerable reset frequency, because the reset will > interrupt services. I am sorry, I still do not understand. Please try explaining this in more detail in the description. > > > + > > > +What: /sys/class/uacce//isolate > > > +Date: Jul 2022 > > > +KernelVersion: 5.20 > > > +Contact: linux-accelerators@lists.ozlabs.org > > > +Description: A sysfs node that read the device isolated state. The value 0 > > > + means that the device is working. The value 1 means that the > > > + device has been isolated. > > > > So 1 means "not working"? This seems odd, perhaps you can rephrase this > > a bit better? > > 1 means the device is unavailable. 0 means the device is available. Then please say that :) thanks, greg k-h