From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3FF79C43334 for ; Sun, 10 Jul 2022 09:45:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229573AbiGJJpn (ORCPT ); Sun, 10 Jul 2022 05:45:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52442 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229450AbiGJJpk (ORCPT ); Sun, 10 Jul 2022 05:45:40 -0400 Received: from mail.skyhub.de (mail.skyhub.de [5.9.137.197]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8790C12778 for ; Sun, 10 Jul 2022 02:45:38 -0700 (PDT) Received: from zn.tnic (p200300ea970ff643329c23fffea6a903.dip0.t-ipconnect.de [IPv6:2003:ea:970f:f643:329c:23ff:fea6:a903]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 20AA91EC01B7; Sun, 10 Jul 2022 11:45:33 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1657446333; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=AKJ430ZgN1XdgA7qMu9v4uYf5Spa2vuStLi0ikdoxF8=; b=AeuVxxsLezyAJPuEwxsCCYZrP9Nk/A5feET5ToU82yk4sTDb1+ZSwhS6Iy0OpPqDL+ndWh MNWh0qrAiNJPHh9oL8XjZ+lZ/RlL6KJNBtQS63Zg/72hGcsfO8RmDWq7BQCd4EOiZ8fYwS A1xL2PiZ/Tm6lfJPsvNfc4VRGjRy+vk= Date: Sun, 10 Jul 2022 11:45:28 +0200 From: Borislav Petkov To: "H. Peter Anvin" Cc: "Jason A. Donenfeld" , Thomas Gleixner , Ingo Molnar , X86 ML , LKML , Andy Lutomirski Subject: Re: [PATCH tip v8] x86/setup: Use rng seeds from setup_data Message-ID: References: <20220707000852.523788-1-Jason@zx2c4.com> <20220708113907.891319-1-Jason@zx2c4.com> <191d8f96-7573-bd0e-9ca4-3fc22c5c9a49@zytor.com> <8e5eb2db-ce31-3dc8-8f75-3959036686f8@zytor.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <8e5eb2db-ce31-3dc8-8f75-3959036686f8@zytor.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Jul 09, 2022 at 03:41:19PM -0700, H. Peter Anvin wrote: > In ABI/API terms, that symbol has the semantic of connecting the API version > to the underlying ABI version; a piece of code that sees an enumeration type > > SETUP_ENUM_MAX must by definition treat it as an opaque blob. In the > future, should it become warranted, we may add flags that indicate how > unaware code should handle them, but I don't think we can engineer that > right now. Ok, let's hope it doesn't come to that and userspace behaves... So, I'm going to send the below to Linus now so that 5.19 releases fixed and then queue Jason's patch next week. Thx. --- From: Borislav Petkov Date: Sun, 10 Jul 2022 11:15:47 +0200 Subject: [PATCH] x86/boot: Fix the setup data types max limit Commit in Fixes forgot to change the SETUP_TYPE_MAX definition which contains the highest valid setup data type. Correct that. Fixes: 5ea98e01ab52 ("x86/boot: Add Confidential Computing type to setup_data") Signed-off-by: Borislav Petkov Link: https://lore.kernel.org/r/ddba81dd-cc92-699c-5274-785396a17fb5@zytor.com --- arch/x86/include/uapi/asm/bootparam.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/include/uapi/asm/bootparam.h b/arch/x86/include/uapi/asm/bootparam.h index bea5cdcdf532..e02a8a8ef23c 100644 --- a/arch/x86/include/uapi/asm/bootparam.h +++ b/arch/x86/include/uapi/asm/bootparam.h @@ -15,7 +15,7 @@ #define SETUP_INDIRECT (1<<31) /* SETUP_INDIRECT | max(SETUP_*) */ -#define SETUP_TYPE_MAX (SETUP_INDIRECT | SETUP_JAILHOUSE) +#define SETUP_TYPE_MAX (SETUP_INDIRECT | SETUP_CC_BLOB) /* ram_size flags */ #define RAMDISK_IMAGE_START_MASK 0x07FF -- 2.35.1 -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette