From: Borislav Petkov <bp@alien8.de>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: linux-kernel@vger.kernel.org,
Linus Torvalds <torvalds@linux-foundation.org>,
Mark Hemment <markhemm@googlemail.com>,
Andrew Morton <akpm@linux-foundation.org>,
the arch/x86 maintainers <x86@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
patrice.chotard@foss.st.com,
Mikulas Patocka <mpatocka@redhat.com>,
Lukas Czerner <lczerner@redhat.com>,
Christoph Hellwig <hch@lst.de>,
"Darrick J. Wong" <djwong@kernel.org>,
Chuck Lever <chuck.lever@oracle.com>,
Hugh Dickins <hughd@google.com>,
patches@lists.linux.dev, Linux-MM <linux-mm@kvack.org>,
mm-commits@vger.kernel.org, Mel Gorman <mgorman@suse.de>
Subject: Re: [PATCH -final] x86/clear_user: Make it faster
Date: Mon, 11 Jul 2022 12:33:20 +0200 [thread overview]
Message-ID: <Ysv8cAa7wcDmQlpm@zn.tnic> (raw)
In-Reply-To: <YsVUvK/zQaIW749P@localhost.localdomain>
On Wed, Jul 06, 2022 at 12:24:12PM +0300, Alexey Dobriyan wrote:
> On Tue, Jul 05, 2022 at 07:01:06PM +0200, Borislav Petkov wrote:
>
> > + asm volatile(
> > + "1:\n\t"
> > + ALTERNATIVE_3("rep stosb",
> > + "call clear_user_erms", ALT_NOT(X86_FEATURE_FSRM),
> > + "call clear_user_rep_good", ALT_NOT(X86_FEATURE_ERMS),
> > + "call clear_user_original", ALT_NOT(X86_FEATURE_REP_GOOD))
> > + "2:\n"
> > + _ASM_EXTABLE_UA(1b, 2b)
> > + : "+&c" (size), "+&D" (addr), ASM_CALL_CONSTRAINT
> > + : "a" (0)
> > + /* rep_good clobbers %rdx */
> > + : "rdx");
>
> "+c" and "+D" should be enough for 1 instruction assembly?
I'm looking at
e0a96129db57 ("x86: use early clobbers in usercopy*.c")
which introduced the early clobbers and I'm thinking we want them
because "this operand is an earlyclobber operand, which is written
before the instruction is finished using the input operands" and we have
exception handling.
But maybe you need to be more verbose as to what you mean exactly...
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
next prev parent reply other threads:[~2022-07-11 11:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAHk-=whCmmipbBDips0OJ=UiBUjZfgBGYruoOsqcq2TVd5kBSA@mail.gmail.com>
[not found] ` <YnqqhmYv75p+xl73@zn.tnic>
[not found] ` <Ynq1nVpu1xCpjnXm@zn.tnic>
[not found] ` <YozQZMyQ0NDdD8cH@zn.tnic>
[not found] ` <YrMlVBoDxB21l/kD@zn.tnic>
[not found] ` <CAHk-=wgmOfipHDvshwooTV81hMh6FHieSvhgGVWZMX8w+E-2DQ@mail.gmail.com>
[not found] ` <YrN4DdR9HN0srNWe@zn.tnic>
[not found] ` <CAHk-=wj_MeMUnKyRDuQTiU1OmQ=gfZVZhcD=G7Uma=1gkKkzxg@mail.gmail.com>
[not found] ` <YrQ1PPB77PBWyaHs@zn.tnic>
[not found] ` <YsRuUl24zkhpE3s/@zn.tnic>
2022-07-06 9:24 ` Alexey Dobriyan
2022-07-11 10:33 ` Borislav Petkov [this message]
2022-07-12 12:32 ` Alexey Dobriyan
2022-08-06 12:49 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ysv8cAa7wcDmQlpm@zn.tnic \
--to=bp@alien8.de \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=chuck.lever@oracle.com \
--cc=djwong@kernel.org \
--cc=hch@lst.de \
--cc=hughd@google.com \
--cc=lczerner@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=markhemm@googlemail.com \
--cc=mgorman@suse.de \
--cc=mm-commits@vger.kernel.org \
--cc=mpatocka@redhat.com \
--cc=patches@lists.linux.dev \
--cc=patrice.chotard@foss.st.com \
--cc=peterz@infradead.org \
--cc=torvalds@linux-foundation.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®