From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3A369CCA481 for ; Mon, 11 Jul 2022 14:41:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231539AbiGKOln (ORCPT ); Mon, 11 Jul 2022 10:41:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35470 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231517AbiGKOlk (ORCPT ); Mon, 11 Jul 2022 10:41:40 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EFD6165551 for ; Mon, 11 Jul 2022 07:41:37 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 8D3CB6154F for ; Mon, 11 Jul 2022 14:41:37 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DEF62C34115; Mon, 11 Jul 2022 14:41:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1657550497; bh=bONJCw5eJMmcoc8rRf6p6ImOc81UA3qM6eCZOEwehdE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=hS97Lc/+nw0Yk0Mn3D7qCB/Me1go3u1l+4zKDmcpzfMCTSQJPfAbUylTn9aLDAc7B khSLsW9+f1BhHSeaD0IFu3pGRBwBiP67iJLiTCo9Taus9cmM3FLEw+zzVv+FDA/BnK AuYhwNoC4PYrk1+xOpuZtYVj5mBGkN8neS+TRhRMXs3fXQQGJvK6ovyTbOJ0wsWhXc JQaN6eHQ3sTimjH9qLx+AA8LuvTikmbkVZWnbY25DOKaZDHxrc4XLR+2cHcxR2LRht cwKsimZAuofEOgLBtUD6T/2Xli15kA3dALdcofr9cANrHHnBPYvUB5KX6htWdRlX5A ACWSf9oqhUN7A== Date: Mon, 11 Jul 2022 15:41:31 +0100 From: Mark Brown To: Alexandru Elisei Cc: lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com, heiko@sntech.de, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, judyhsiao@chromium.org Subject: Re: [PATCH] ASoC: rockchip: i2s: Fix NULL pointer dereference when pinctrl is not found Message-ID: References: <20220711130522.401551-1-alexandru.elisei@arm.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="WbHIuEdIlgHTyV0d" Content-Disposition: inline In-Reply-To: X-Cookie: I am NOMAD! Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --WbHIuEdIlgHTyV0d Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jul 11, 2022 at 02:40:08PM +0100, Alexandru Elisei wrote: > On Mon, Jul 11, 2022 at 02:23:59PM +0100, Mark Brown wrote: > > Please think hard before including complete backtraces in upstream > > reports, they are very large and contain almost no useful information > I'm at a loss here. Are you saying that those 4 lines represent a complete > backtrace and they are very large? Or are you talking about the panic log > that I've included in the commit message? I'm talking about the entire log that that was the start of, I deleted the bulk of it due to the excessive size. > > relative to their size so often obscure the relevant content in your > > message. If part of the backtrace is usefully illustrative (it often is > > for search engines if nothing else) then it's usually better to pull out > > the relevant sections. > Would you mind pointing out what you think the relevant sections are? I > would also find it very useful (for future patches) if you can explain why > they are relevant, and why those parts you've left out aren't. It's not > very easy to figure out what is relevant when you're not familiar with a > subsystem. It really depends what the information you're trying to convey with the backtrace is, in general a couple of frames of context might be useful if there's something interesting about the context from which things were called since that's the unique bit that people might search for. For example things like the standard set of generic functions you'd see when probing a device is rarely going to convey anything meaningful, and similarly the standard kernel entry backtrace for something triggered =66rom a system call. The full register state is also commonly not of any great relevance if it's not illustrating something in the rest of the message.=20 If you are just including an entire splat on the off chance that it might be relevant consider just not including it rather than including everything. --WbHIuEdIlgHTyV0d Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmLMNpoACgkQJNaLcl1U h9A2RAf+N0AAEGr/N2lYkhPRA9ScXTpy5ypMOXGfYbxd9cx5STM9WUG5VDyMiCDL 9WlBtSWFVXiRKae6env9zFsCAWWQPFr0KRlTgRDX2buDhyorm6LF85qOddnmkJQc nLv6nKoR25X8ODyldf4MGn28cp3x+vj0SmBhncY3jmjWRWfo9TVmpDVTM/MH+cyD WuVixZH6n/fyZ0OTTi0dTz15fm00chqk+lMXjOrXolz3lqc7T2WkPZRNadBjhNhY JV+sRaogmIL9dSPrPmnkuhszS3mDBUPTiMnYqhogf+vajTip7on89K67toG/ff5x t4bVqxlzEkSaRnTvGBn2aXG/Xn466w== =dvsB -----END PGP SIGNATURE----- --WbHIuEdIlgHTyV0d--