mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Luis Chamberlain <mcgrof@kernel.org>
To: Aaron Tomlin <atomlin@redhat.com>
Cc: rostedt@goodmis.org, cl@linux.com, pmladek@suse.com,
	mbenes@suse.cz, christophe.leroy@csgroup.eu,
	akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
	linux-modules@vger.kernel.org, atomlin@atomlin.com,
	ghalat@redhat.com, oleksandr@natalenko.name, neelx@redhat.com,
	daniel.thompson@linaro.org, hch@infradead.org,
	tglx@linutronix.de, adrian.hunter@intel.com,
	linux-rt-users@vger.kernel.org
Subject: Re: [PATCH v3 -next 1/1] module: kallsyms: Ensure preemption in add_kallsyms() with PREEMPT_RT
Date: Mon, 11 Jul 2022 10:32:35 -0700	[thread overview]
Message-ID: <Ysxes81GjdNK3yE+@bombadil.infradead.org> (raw)
In-Reply-To: <20220711171719.1244255-2-atomlin@redhat.com>

On Mon, Jul 11, 2022 at 06:17:19PM +0100, Aaron Tomlin wrote:
> The commit 08126db5ff73 ("module: kallsyms: Fix suspicious rcu usage")
> under PREEMPT_RT=y, disabling preemption introduced an unbounded
> latency since the loop is not fixed. This change caused a regression
> since previously preemption was not disabled and we would dereference
> RCU-protected pointers explicitly. That being said, these pointers
> cannot change.
> 
> Before kallsyms-specific data is prepared/or set-up, we ensure that
> the unformed module is known to be unique i.e. does not already exist
> (see load_module()). Therefore, we can fix this by using the common and
> more appropriate RCU flavour as this section of code can be safely
> preempted.
> 
> Reported-by: Steven Rostedt <rostedt@goodmis.org>
> Fixes: 08126db5ff73 ("module: kallsyms: Fix suspicious rcu usage")
> Signed-off-by: Aaron Tomlin <atomlin@redhat.com>

Thanks! Queued up!

  Luis

      reply	other threads:[~2022-07-11 17:32 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-11 17:17 [PATCH v3 -next 0/1] " Aaron Tomlin
2022-07-11 17:17 ` [PATCH v3 -next 1/1] " Aaron Tomlin
2022-07-11 17:32   ` Luis Chamberlain [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Ysxes81GjdNK3yE+@bombadil.infradead.org \
    --to=mcgrof@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=akpm@linux-foundation.org \
    --cc=atomlin@atomlin.com \
    --cc=atomlin@redhat.com \
    --cc=christophe.leroy@csgroup.eu \
    --cc=cl@linux.com \
    --cc=daniel.thompson@linaro.org \
    --cc=ghalat@redhat.com \
    --cc=hch@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-modules@vger.kernel.org \
    --cc=linux-rt-users@vger.kernel.org \
    --cc=mbenes@suse.cz \
    --cc=neelx@redhat.com \
    --cc=oleksandr@natalenko.name \
    --cc=pmladek@suse.com \
    --cc=rostedt@goodmis.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®