From: Yazen Ghannam <yazen.ghannam@amd.com>
To: Borislav Petkov <bp@alien8.de>
Cc: linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org,
tony.luck@intel.com, x86@kernel.org,
Smita.KoralahalliChannabasappa@amd.com
Subject: Re: [PATCH 3/3] EDAC/mce_amd: Add support for FRU Text in MCA
Date: Mon, 11 Jul 2022 17:41:54 +0000 [thread overview]
Message-ID: <Ysxg4r1IAA2PasTC@yaz-fattaah> (raw)
In-Reply-To: <YsKvVI/t2svrib1L@zn.tnic>
On Mon, Jul 04, 2022 at 11:13:56AM +0200, Borislav Petkov wrote:
> On Mon, Apr 18, 2022 at 05:44:40PM +0000, Yazen Ghannam wrote:
> > @@ -1254,11 +1255,10 @@ amd_decode_mce(struct notifier_block *nb, unsigned long val, void *data)
> > ((m->status & MCI_STATUS_PCC) ? "PCC" : "-"));
> >
> > if (boot_cpu_has(X86_FEATURE_SMCA)) {
> > - u32 low, high;
> > u32 addr = MSR_AMD64_SMCA_MCx_CONFIG(m->bank);
> >
> > - if (!rdmsr_safe(addr, &low, &high) &&
> > - (low & MCI_CONFIG_MCAX))
> > + if (!rdmsrl_safe_on_cpu(m->extcpu, addr, &mca_config) &&
>
> This change needs to be mentioned in the commit message.
>
Okay.
> > + (mca_config & MCI_CONFIG_MCAX))
> > pr_cont("|%s", ((m->status & MCI_STATUS_TCC) ? "TCC" : "-"));
> >
> > pr_cont("|%s", ((m->status & MCI_STATUS_SYNDV) ? "SyndV" : "-"));
> > @@ -1300,6 +1300,17 @@ amd_decode_mce(struct notifier_block *nb, unsigned long val, void *data)
> > pr_cont("\n");
>
> So here above the code prints SYND1 and SYND2.
>
> If they contain FRU strings, then this printing should be an if-else by
> checking bit 9.
>
> if (BIT(9))
> print fru text
> else
> print naked syndromes
>
>
Okay, will change.
> > decode_smca_error(m);
> > +
> > + if (mca_config & BIT(9)) {
> > + char frutext[32];
>
> Why 32?
>
I picked the next power of 2 after 16 in order to have some space for
terminating NULL in the string. I can't think of a good reason it needs to be
a power of 2, so I can change this to 17.
> > + memset(frutext, 0, sizeof(frutext));
> > + memcpy(&frutext[0], &m->synd1, 8);
> > + memcpy(&frutext[8], &m->synd2, 8);
> > +
> > + pr_emerg(HW_ERR "FRU Text: %s\n", frutext);
> > + }
> > +
> > goto err_code;
> > }
>
Thanks,
Yazen
next prev parent reply other threads:[~2022-07-11 17:42 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-18 17:44 [PATCH 0/3] New SMCA Syndrome registers and FRU Text feature Yazen Ghannam
2022-04-18 17:44 ` [PATCH 1/3] x86/MCE, EDAC/mce_amd: Add support for new MCA_SYND{1,2} registers Yazen Ghannam
2022-06-30 11:01 ` Borislav Petkov
2022-07-11 17:31 ` Yazen Ghannam
2022-07-18 8:57 ` Borislav Petkov
2022-07-18 13:50 ` Borislav Petkov
2022-08-02 12:22 ` Yazen Ghannam
2022-08-02 16:58 ` Luck, Tony
2022-10-24 16:09 ` Borislav Petkov
2022-10-24 16:38 ` Tony Luck
2022-10-24 20:30 ` Borislav Petkov
2022-10-24 21:08 ` Luck, Tony
2022-10-24 21:23 ` Borislav Petkov
2022-10-24 21:32 ` Luck, Tony
2022-10-24 21:52 ` Luck, Tony
2022-10-25 16:35 ` Yazen Ghannam
2022-10-25 16:46 ` Luck, Tony
2022-10-25 18:05 ` Borislav Petkov
2022-10-25 19:28 ` Steven Rostedt
2022-11-01 17:27 ` Yazen Ghannam
2022-04-18 17:44 ` [PATCH 2/3] x86/MCE/APEI: Handle variable register array size Yazen Ghannam
2022-07-03 12:30 ` Borislav Petkov
2022-07-11 17:32 ` Yazen Ghannam
2022-04-18 17:44 ` [PATCH 3/3] EDAC/mce_amd: Add support for FRU Text in MCA Yazen Ghannam
2022-07-04 9:13 ` Borislav Petkov
2022-07-11 17:41 ` Yazen Ghannam [this message]
2022-06-10 16:29 ` [PATCH 0/3] New SMCA Syndrome registers and FRU Text feature Yazen Ghannam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ysxg4r1IAA2PasTC@yaz-fattaah \
--to=yazen.ghannam@amd.com \
--cc=Smita.KoralahalliChannabasappa@amd.com \
--cc=bp@alien8.de \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®