mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Alexey Klimov <klimov.linux@gmail.com>
Cc: linux-watchdog@vger.kernel.org, wim@linux-watchdog.org,
	linux@roeck-us.net, oneukum@suse.com, linux-usb@vger.kernel.org,
	linux-kernel@vger.kernel.org, atishp@rivosinc.com,
	atishp@atishpatra.org, yury.norov@gmail.com, aklimov@redhat.com,
	atomlin@redhat.com
Subject: Re: [PATCH v5] watchdog: add driver for StreamLabs USB watchdog device
Date: Mon, 25 Jul 2022 10:51:43 +0200	[thread overview]
Message-ID: <Yt5Zn9cXDe9/F9RJ@kroah.com> (raw)
In-Reply-To: <20220725030605.1808710-1-klimov.linux@gmail.com>

On Mon, Jul 25, 2022 at 04:06:05AM +0100, Alexey Klimov wrote:
> +static bool nowayout = WATCHDOG_NOWAYOUT;
> +module_param(nowayout, bool, 0);
> +MODULE_PARM_DESC(nowayout, "Watchdog cannot be stopped once started (default="
> +			__MODULE_STRING(WATCHDOG_NOWAYOUT) ")");
> +

Meta-comment about watchdog drivers, this is per-driver, not per-device,
which does not make sense for when these devices are on removable busses
where you can have multiple ones.

I don't suggest changing this (as it follows the current style of other
watchdog drivers), but perhaps a sysfs attribute for watchdog devices
can do the same thing in the future so you can do this on a per-device
basis.

Anyway, driver looks good to me, nice work!

Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

  reply	other threads:[~2022-07-25  8:51 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-25  3:06 Alexey Klimov
2022-07-25  8:51 ` Greg KH [this message]
2022-07-25 14:07   ` Guenter Roeck
2022-07-26  0:21   ` Alexey Klimov
2022-07-26  7:48     ` Oliver Neukum
2022-07-31  2:34       ` Alexey Klimov
2022-07-31  8:20         ` Guenter Roeck
2022-07-31 14:17           ` Alan Stern
2022-08-01  4:00             ` Alexey Klimov
2022-08-01  3:06           ` Alexey Klimov
2022-08-01  9:47         ` Oliver Neukum
2022-07-25 14:02 ` Guenter Roeck
2022-07-26  1:31   ` Alexey Klimov
2022-07-26  3:24     ` Guenter Roeck
2022-08-01  2:58       ` Alexey Klimov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Yt5Zn9cXDe9/F9RJ@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=aklimov@redhat.com \
    --cc=atishp@atishpatra.org \
    --cc=atishp@rivosinc.com \
    --cc=atomlin@redhat.com \
    --cc=klimov.linux@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=oneukum@suse.com \
    --cc=wim@linux-watchdog.org \
    --cc=yury.norov@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®