From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65339C433EF for ; Mon, 25 Jul 2022 12:47:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235251AbiGYMrL (ORCPT ); Mon, 25 Jul 2022 08:47:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51898 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233546AbiGYMrI (ORCPT ); Mon, 25 Jul 2022 08:47:08 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 59B2413F7B; Mon, 25 Jul 2022 05:47:06 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 01A2AB80DEB; Mon, 25 Jul 2022 12:47:05 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D26BAC341C8; Mon, 25 Jul 2022 12:47:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1658753223; bh=gG70nkexN6R7rwhZbK7zPzM/h4w2zfhGvxObm6YIeIc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=2MmEMBkhDaPYKBOsckNO7rs8nAwmvC4NddHh3ez0D31mowqKbqiVtOedbV6raS4bL /Yme7QUrqrEZmhRWYIwNKKw0gwXO1LHWEcoj5MxB8dblyHt4VG25F5zT3LyZrPGw75 SbhrKqEeA2kZFURSoLHCEx8+S4QE1ZsC0OH6QsQk= Date: Mon, 25 Jul 2022 14:46:59 +0200 From: Greg KH To: Yuji Ishikawa Cc: Rob Herring , Hans Verkuil , Nobuhiro Iwamatsu , Jonathan Corbet , Sumit Semwal , Christian =?iso-8859-1?Q?K=F6nig?= , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org Subject: Re: [PATCH v2 0/5] Add Toshiba Visconti DNN image processing accelerator driver Message-ID: References: <20220722082858.17880-1-yuji2.ishikawa@toshiba.co.jp> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220722082858.17880-1-yuji2.ishikawa@toshiba.co.jp> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 22, 2022 at 05:28:53PM +0900, Yuji Ishikawa wrote: > This series is the DNN image processing accelerator driver for Toshiba's ARM SoC, Visconti[0]. > This provides DT binding documentation, device driver, MAINTAINER files and documents. > > Best regards, > Yuji > > [0]: https://toshiba.semicon-storage.com/ap-en/semiconductor/product/image-recognition-processors-visconti.html > > dt-bindings: soc: visconti: Add Toshiba Visconti DNN image processing accelerator bindings > v1 -> v2: > - No update > > soc: visconti: Add Toshiba Visconti image processing accelerator common source > v1 -> v2: > - checked with checkpatch.pl --strict > > soc: visconti: Add Toshiba Visconti DNN image processing accelerator > v1 -> v2: > - checked with checkpatch.pl --strict > - removed unused code > > MAINTAINERS: Add entries for Toshiba Visconti DNN image processing > v1 -> v2: > - No update > > Documentation: driver-api: visconti: add a description of DNN driver. > v1 -> v2: > - newly added documents > > Yuji Ishikawa (5): > dt-bindings: soc: visconti: Add Toshiba Visconti DNN image processing > accelerator bindings > soc: visconti: Add Toshiba Visconti image processing accelerator > common source > soc: visconti: Add Toshiba Visconti DNN image processing accelerator > MAINTAINERS: Add entries for Toshiba Visconti DNN image processing > accelerator > Documentation: driver-api: visconti: add a description of DNN driver. > > .../soc/visconti/toshiba,visconti-dnn.yaml | 54 ++ > Documentation/driver-api/visconti/common.rst | 115 ++++ > Documentation/driver-api/visconti/dnn.rst | 394 +++++++++++++ > MAINTAINERS | 2 + > drivers/soc/Kconfig | 1 + > drivers/soc/Makefile | 1 + > drivers/soc/visconti/Kconfig | 7 + > drivers/soc/visconti/Makefile | 8 + > drivers/soc/visconti/dnn/Makefile | 6 + > drivers/soc/visconti/dnn/dnn.c | 523 ++++++++++++++++++ > drivers/soc/visconti/dnn/hwd_dnn.c | 183 ++++++ > drivers/soc/visconti/dnn/hwd_dnn.h | 68 +++ > drivers/soc/visconti/dnn/hwd_dnn_reg.h | 228 ++++++++ > drivers/soc/visconti/ipa_common.c | 55 ++ > drivers/soc/visconti/ipa_common.h | 18 + > drivers/soc/visconti/uapi/dnn.h | 77 +++ > drivers/soc/visconti/uapi/ipa.h | 90 +++ Why is this in drivers/soc/? And uapi files belong in the correct include path, not burried in a driver subdirectory where they will never be picked up correctly by the build system. How did you test these? thanks, greg k-h