From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id ACE7AC433EF for ; Thu, 14 Jul 2022 20:40:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231500AbiGNUkl (ORCPT ); Thu, 14 Jul 2022 16:40:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52384 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232494AbiGNUkh (ORCPT ); Thu, 14 Jul 2022 16:40:37 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8CB1E4AD59 for ; Thu, 14 Jul 2022 13:40:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=0UbINprXHIcKJelLt5cQiiEIcF3SWv0kgbs5wFpce5I=; b=OwTfcA+5EOw+rzbYKBLqpXAZIC vPcNmmcZack8E6GSTNiHw43ysh8Zhj/EGmfvoM6Ikgyc8OMwPOpcDXU/Ol42zfclAX6q6e6/Fde63 vKBDFPpxP4L2LTx4MBAz0kk95+xez6SjmQWzLvGXIJVSchN+1mW/93EAWGdKQNHOiszJPbBqKaGdT 2XlDj+oIAmc7Zsqyd7S645/JI/IQCmd+LcS2wsPXG27vMcyFEuVsXK5fjbAebyNnaSnOhCmjr938x DTjmUrOaJA8OREiHqIIQEM18N2I71XQQ5OlA6ZQ6lRenwurwx0Bn/GzGi4nOTEnfY6oISlSWP0yTa 3anW2NUw==; Received: from mcgrof by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1oC5dQ-001WE8-Ba; Thu, 14 Jul 2022 20:40:32 +0000 Date: Thu, 14 Jul 2022 13:40:32 -0700 From: Luis Chamberlain To: Greg Kroah-Hartman Cc: "Fabio M. De Francesco" , Russ Weight , "Rafael J. Wysocki" , Nick Terrell , linux-kernel@vger.kernel.org, Ira Weiny Subject: Re: [PATCH] firmware_loader: Replace kmap() with kmap_local_page() Message-ID: References: <20220710101156.26139-1-fmdefrancesco@gmail.com> <1891319.taCxCBeP46@opensuse> <2140056.NgBsaNRSFp@opensuse> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: Luis Chamberlain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 14, 2022 at 04:50:42PM +0200, Greg Kroah-Hartman wrote: > On Mon, Jul 11, 2022 at 08:52:49PM +0200, Fabio M. De Francesco wrote: > > > > I see that the outputs of selftests, regardless of running a 5.19.0-rc6 > > kernel with or without my changes, show always the same error: > > > > "not ok 1 selftests: firmware: fw_run_tests.sh # TIMEOUT 165 seconds".". > > > > I ran those tests on a QEMU/KVM 32-bits VM, booting a vanilla 5.19.0-rc6 > > kernel with HIGHMEM64GB enabled. > > > > As said, outputs don't change with or without my patch. Instead it changes > > with the latest openSUSE stock kernel (5.18.9-2-pae): > > > > "ok 1 selftests: firmware: fw_run_tests.sh". > > > > Unfortunately, I'm not familiar with kernel selftests. Any ideas about what > > could have made this tests fail? Is it expected? > > > > If not, I can try and figure out why these outputs are not what they should > > be (the second version of my patch can wait the time it takes). > > No idea, sorry, Luis might know more. The selftests should have a config file, ensure that stuff is all enabled. Can you verify if this stuff was enabled on your config: cat tools/testing/selftests/firmware/config CONFIG_TEST_FIRMWARE=y CONFIG_FW_LOADER=y CONFIG_FW_LOADER_USER_HELPER=y CONFIG_IKCONFIG=y CONFIG_IKCONFIG_PROC=y CONFIG_FW_UPLOAD=y Luis