From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4269AC433EF for ; Fri, 15 Jul 2022 05:25:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229966AbiGOFZw (ORCPT ); Fri, 15 Jul 2022 01:25:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57924 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229730AbiGOFZt (ORCPT ); Fri, 15 Jul 2022 01:25:49 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0E2BE79EE1; Thu, 14 Jul 2022 22:25:49 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id AA8D7B82A9C; Fri, 15 Jul 2022 05:25:47 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 94F7FC341C6; Fri, 15 Jul 2022 05:25:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1657862746; bh=LibR5gdvV1FppPi6j75ld0+91VGoEGhnyLiUEP6tYQ0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=mtMKX97g3Hj6YyhNNICTmKA5pXMgFEWWpCPjBDfGUw5IYNXyXHPCnsnk4MlOZ+s8c 1TqvylvtTct8JUGejaqXrdKyK4l96fFrfPmGwZ5baFt0YO/wvEr0VOPbx6BYCDa2gV W7WJxSabjjXH0SAQq1ZVU+e3upO2rVp51qr10OLk= Date: Fri, 15 Jul 2022 07:25:43 +0200 From: Greg KH To: Pawan Gupta Cc: Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , linux-kernel@vger.kernel.org, stable@vger.kernel.org, Daniel Sneddon , antonio.gomez.iglesias@linux.intel.com, Josh Poimboeuf Subject: Re: [PATCH v2] x86/bugs: Warn when "ibrs" mitigation is selected on Enhanced IBRS parts Message-ID: References: <0456b35fb9ef957d9a9138e0913fb1a3fd445dff.1657747493.git.pawan.kumar.gupta@linux.intel.com> <2a5eaf54583c2bfe0edc4fea64006656256cca17.1657814857.git.pawan.kumar.gupta@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2a5eaf54583c2bfe0edc4fea64006656256cca17.1657814857.git.pawan.kumar.gupta@linux.intel.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 14, 2022 at 04:15:35PM -0700, Pawan Gupta wrote: > IBRS mitigation for spectre_v2 forces write to MSR_IA32_SPEC_CTRL at > every kernel entry/exit. On Enhanced IBRS parts setting > MSR_IA32_SPEC_CTRL[IBRS] only once at boot is sufficient. MSR writes at > every kernel entry/exit incur unnecessary performance loss. > > When Enhanced IBRS feature is present, print a warning about this > unnecessary performance loss. > > Signed-off-by: Pawan Gupta > --- > v1->v2: Instead of changing the mitigation, print a warning about the > perf loss. > > v1: https://lore.kernel.org/lkml/0456b35fb9ef957d9a9138e0913fb1a3fd445dff.1657747493.git.pawan.kumar.gupta@linux.intel.com/ > > arch/x86/kernel/cpu/bugs.c | 3 +++ > 1 file changed, 3 insertions(+) This is not the correct way to submit patches for inclusion in the stable kernel tree. Please read: https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html for how to do this properly.