From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Sumeet Pawnikar <sumeet.r.pawnikar@intel.com>
Cc: rafael@kernel.org, srinivas.pandruvada@linux.intel.com,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] powercap: RAPL: Add Power Limit4 support for Alder Lake-N and Raptor Lake-P
Date: Fri, 15 Jul 2022 22:48:39 +0300 [thread overview]
Message-ID: <YtHEl73BL1BRyl9r@smile.fi.intel.com> (raw)
In-Reply-To: <20220715165228.28044-1-sumeet.r.pawnikar@intel.com>
On Fri, Jul 15, 2022 at 10:22:28PM +0530, Sumeet Pawnikar wrote:
> Add Alder Lake-N and Raptor Lake-P to the list of processor models
> for which Power Limit4 is supported by the Intel RAPL driver.
>
> Signed-off-by: Sumeet Pawnikar <sumeet.r.pawnikar@intel.com>
> Reviewed-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
You may not convert people's review into a tag without their consent.
But taking into account this is trivial patch, it's fine. Just follow
the rules next time.
Also, where is v1? What are the differences to it?
> ---
> drivers/powercap/intel_rapl_msr.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/powercap/intel_rapl_msr.c b/drivers/powercap/intel_rapl_msr.c
> index 9d23984d8931..bc6adda58883 100644
> --- a/drivers/powercap/intel_rapl_msr.c
> +++ b/drivers/powercap/intel_rapl_msr.c
> @@ -140,7 +140,9 @@ static const struct x86_cpu_id pl4_support_ids[] = {
> { X86_VENDOR_INTEL, 6, INTEL_FAM6_TIGERLAKE_L, X86_FEATURE_ANY },
> { X86_VENDOR_INTEL, 6, INTEL_FAM6_ALDERLAKE, X86_FEATURE_ANY },
> { X86_VENDOR_INTEL, 6, INTEL_FAM6_ALDERLAKE_L, X86_FEATURE_ANY },
> + { X86_VENDOR_INTEL, 6, INTEL_FAM6_ALDERLAKE_N, X86_FEATURE_ANY },
> { X86_VENDOR_INTEL, 6, INTEL_FAM6_RAPTORLAKE, X86_FEATURE_ANY },
> + { X86_VENDOR_INTEL, 6, INTEL_FAM6_RAPTORLAKE_P, X86_FEATURE_ANY },
> {}
> };
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2022-07-15 19:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-15 16:52 Sumeet Pawnikar
2022-07-15 19:48 ` Andy Shevchenko [this message]
2022-07-19 14:33 ` Pawnikar, Sumeet R
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YtHEl73BL1BRyl9r@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=srinivas.pandruvada@linux.intel.com \
--cc=sumeet.r.pawnikar@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®