From: Matthew Wilcox <willy@infradead.org>
To: David Sterba <dsterba@suse.com>,
torvalds@linux-foundation.org, linux-btrfs@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [GIT PULL] Btrfs fixes for 5.19-rc7
Date: Sat, 16 Jul 2022 16:34:12 +0100 [thread overview]
Message-ID: <YtLadOkHl0lDNwbM@casper.infradead.org> (raw)
In-Reply-To: <cover.1657976305.git.dsterba@suse.com>
On Sat, Jul 16, 2022 at 04:06:20PM +0200, David Sterba wrote:
> Note about the xarray API:
>
> The possible sleeping is documented next to xa_insert, however there's
> no runtime check for that, like is eg. in radix_tree_preload. The
> context does not need to be atomic so it's not as simple as
>
> might_sleep_if(gfpflags_allow_blocking(gfp));
>
> or
>
> WARN_ON_ONCE(gfpflags_allow_blocking(gfp));
>
> Some kind of development time debugging/assertion aid would be nice.
Are you saying that
https://git.infradead.org/users/willy/xarray.git/commitdiff/c195d497ca1ff673c2e6935152a0a5b6be2efdc9
is wrong? It's been in linux-next for the last week since you drew it
to my attention that this would be useful.
next prev parent reply other threads:[~2022-07-16 15:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-16 14:06 David Sterba
2022-07-16 15:34 ` Matthew Wilcox [this message]
2022-07-21 14:45 ` David Sterba
2022-07-21 15:43 ` David Sterba
2022-07-16 22:10 ` pr-tracker-bot
-- strict thread matches above, loose matches on Subject: below --
2022-07-11 21:16 David Sterba
2022-07-11 21:44 ` pr-tracker-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YtLadOkHl0lDNwbM@casper.infradead.org \
--to=willy@infradead.org \
--cc=dsterba@suse.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®