From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 19B34CCA479 for ; Sat, 16 Jul 2022 18:18:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230231AbiGPSSG (ORCPT ); Sat, 16 Jul 2022 14:18:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36712 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229505AbiGPSSD (ORCPT ); Sat, 16 Jul 2022 14:18:03 -0400 Received: from vps0.lunn.ch (vps0.lunn.ch [185.16.172.187]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 354AA1D30E; Sat, 16 Jul 2022 11:18:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=Zhn6tvE5+8CyuVHKgG04QJMIHxjVmfp1yFh7W+dOEn0=; b=ckUpcQkpziX4I/aTi7P9MUk6Cx YA50TTZq5d9JssCLzR3TLz+NAWAY0OyJbcAXmc9Krr3Zpb7k6J58i9VMMo9GBh14SZgNV1cFRfTOy kpB5YBIGQbFiQcHGzet0pHGwJf6QXtTyZdq5/aCIGwCKUcO+jpkABPXAYZdwh2Lfgc94=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1oCmM8-00AZ7p-4L; Sat, 16 Jul 2022 20:17:32 +0200 Date: Sat, 16 Jul 2022 20:17:32 +0200 From: Andrew Lunn To: Sean Anderson Cc: "David S . Miller" , Jakub Kicinski , Madalin Bucur , netdev@vger.kernel.org, Paolo Abeni , Eric Dumazet , linux-arm-kernel@lists.infradead.org, Russell King , linux-kernel@vger.kernel.org, Alexandru Marginean , Heiner Kallweit , Vladimir Oltean Subject: Re: [PATCH net-next v3 12/47] net: phy: aquantia: Add support for AQR115 Message-ID: References: <20220715215954.1449214-1-sean.anderson@seco.com> <20220715215954.1449214-13-sean.anderson@seco.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220715215954.1449214-13-sean.anderson@seco.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 15, 2022 at 05:59:19PM -0400, Sean Anderson wrote: > This adds support for the AQR115 (which I have on my LS1046A RDB). I had a > quick look over the registers, and it seems to be compatible with the > AQR107. I couldn't find this oui anywhere, but that's what I have on my > board. It's possible that NXP used a substitute here; I can't confirm > the part number since there is a heatsink on top of the phy. If i remember correctly, the OUI can be part of the provisioning for Aquantia PHYs. And i think there is often per board provisioning, specially for the SERDEs configuration. So aQuantia/Marvell probably set this OUI, but maybe at NXP request. Did you get the part number from the schematic? That should be enough to confirm it is a AQR115. > To avoid breaking <10G ethernet on the LS1046ARDB, we must add this > vendor id as an exception to dpaa_phy_init. This will be removed once > the DPAA driver is converted to phylink. I suggest you split this into two. The PHY changes can be merged right away, and is independent of the DPAA. Given the size of this patchset, the more you can split it up into parallel submissions the better. So please submit the PHY patches independent of the rest. > Signed-off-by: Sean Anderson For the aquantia_main.c change only: Reviewed-by: Andrew Lunn Andrew