From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2D3B0C43334 for ; Sun, 17 Jul 2022 23:04:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232835AbiGQXEI (ORCPT ); Sun, 17 Jul 2022 19:04:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60170 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232300AbiGQXEF (ORCPT ); Sun, 17 Jul 2022 19:04:05 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9FBCB12A8C; Sun, 17 Jul 2022 16:04:04 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 12B9060ECE; Sun, 17 Jul 2022 23:04:04 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3C09EC341C0; Sun, 17 Jul 2022 23:04:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1658099043; bh=IPeBIHmETf2O6wdyfCK0PR/zEOWzTcVCzm7iP2DJHDU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=RgQq0B6e+i5l9xDOvXFdov0SJX+cZ0qaW54Lug3UowEykKCTpf0es9VM+tS4CCAnF IrDb1y+v1xkrc2+PnqpVOG2BiaTC5AZF6C7HZbin9M/fOttDIW/SKcEJOnearBm0E4 W+F5k/2NR24Ac454Qlmzojs0ohoF2FHzIYm3MW0UjKQeQWeEFnMYrvP424BXeJG4Xl omuV/ZWdxgZxNM6fJlvQTom2tmNIuTTLRxhdxw4WTirATWgHQPF52iFOrfh08ddE/O farPpHz/MVdnbi8+mHXmvCCVnNwNE2Tw1fNcwRmD4bXITd8qlkeItkN5g3k35ST3x6 viaQ2ogp096vg== Date: Sun, 17 Jul 2022 19:04:02 -0400 From: Sasha Levin To: Chen-Yu Tsai Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, Judy Hsiao , Mark Brown , lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com, heiko@sntech.de, alsa-devel@alsa-project.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org Subject: Re: [PATCH AUTOSEL 5.15 12/28] ASoC: rockchip: i2s: switch BCLK to GPIO Message-ID: References: <20220714042429.281816-1-sashal@kernel.org> <20220714042429.281816-12-sashal@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 14, 2022 at 12:29:27PM +0800, Chen-Yu Tsai wrote: >Hi, > >On Thu, Jul 14, 2022 at 12:25 PM Sasha Levin wrote: >> >> From: Judy Hsiao >> >> [ Upstream commit a5450aba737dae3ee1a64b282e609d8375d6700c ] >> >> We discoverd that the state of BCLK on, LRCLK off and SD_MODE on >> may cause the speaker melting issue. Removing LRCLK while BCLK >> is present can cause unexpected output behavior including a large >> DC output voltage as described in the Max98357a datasheet. >> >> In order to: >> 1. prevent BCLK from turning on by other component. >> 2. keep BCLK and LRCLK being present at the same time >> >> This patch switches BCLK to GPIO func before LRCLK output, and >> configures BCLK func back during LRCLK is output. >> >> Without this fix, BCLK is turned on 11 ms earlier than LRCK by the >> da7219. >> With this fix, BCLK is turned on only 0.4 ms earlier than LRCK by >> the rockchip codec. >> >> Signed-off-by: Judy Hsiao >> Link: https://lore.kernel.org/r/20220615045643.3137287-1-judyhsiao@chromium.org >> Signed-off-by: Mark Brown >> Signed-off-by: Sasha Levin > >Please drop this one from all stable branches. It caused more problems >than it fixed and will be reverted for 5.19 [1]. The same patch, along >with a proper follow-up fix, are queued up for 5.20. Now dropped, thanks! -- Thanks, Sasha