From: Greg KH <gregkh@linuxfoundation.org>
To: Gaosheng Cui <cuigaosheng1@huawei.com>
Cc: srinivas.kandagatla@linaro.org, rafael@kernel.org,
linux-kernel@vger.kernel.org, gongruiqi1@huawei.com,
wangweiyang2@huawei.com
Subject: Re: [PATCH -next] nvmem: node: using put_device to replace kfree_const
Date: Mon, 18 Jul 2022 16:22:49 +0200 [thread overview]
Message-ID: <YtVsuS1J4h5F+KCG@kroah.com> (raw)
In-Reply-To: <20220718130612.3122982-1-cuigaosheng1@huawei.com>
On Mon, Jul 18, 2022 at 09:06:12PM +0800, Gaosheng Cui wrote:
> We should never be touching the name pointer of a kobject
> directly like this, the device structure itself should be
> cleaning up the memory, not a kfree_const, so using put_device
> to replace kfree_const.
>
> Signed-off-by: Gaosheng Cui <cuigaosheng1@huawei.com>
> ---
> drivers/base/node.c | 2 +-
Please slow down.
Your subject does not match the file name you changed. Stop and wait a
few days, fix up your patches based on the review, and send a patch
series and then wait for others to review them.
While you wait, take some time and review patches from others, so that
you can get some experience here.
good luck
greg k-h
prev parent reply other threads:[~2022-07-18 14:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-18 13:06 Gaosheng Cui
2022-07-18 14:22 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YtVsuS1J4h5F+KCG@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=cuigaosheng1@huawei.com \
--cc=gongruiqi1@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=wangweiyang2@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®