mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: Jason Wang <wangborong@cdjrlc.com>
Cc: mchehab@kernel.org, laurent.pinchart@ideasonboard.com,
	linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] media: mc-request.c: Fix comment typo
Date: Mon, 18 Jul 2022 21:56:37 +0000	[thread overview]
Message-ID: <YtXXFZzMnL5IJZoZ@paasikivi.fi.intel.com> (raw)
In-Reply-To: <20220715051646.30195-1-wangborong@cdjrlc.com>

Hi Jason,

On Fri, Jul 15, 2022 at 01:16:46PM +0800, Jason Wang wrote:
> The double `that' is duplicated in line 162, remove one.
> 
> Signed-off-by: Jason Wang <wangborong@cdjrlc.com>
> ---
>  drivers/media/mc/mc-request.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/media/mc/mc-request.c b/drivers/media/mc/mc-request.c
> index addb8f2d8939..752ea0bc804b 100644
> --- a/drivers/media/mc/mc-request.c
> +++ b/drivers/media/mc/mc-request.c
> @@ -159,7 +159,7 @@ static long media_request_ioctl_queue(struct media_request *req)
>  	 * state can only happen if either the driver changes the state or if
>  	 * the user cancels the vb2 queue. The driver can only change the state
>  	 * after each object is queued through the req_queue op (and note that
> -	 * that op cannot fail), so setting the state to QUEUED up front is

In this case, the second "that" is there for a reason.

> +	 * op cannot fail), so setting the state to QUEUED up front is
>  	 * safe.
>  	 *
>  	 * The other reason for changing the state is if the vb2 queue is

-- 
Sakari Ailus

      reply	other threads:[~2022-07-18 21:56 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-15  5:16 Jason Wang
2022-07-18 21:56 ` Sakari Ailus [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YtXXFZzMnL5IJZoZ@paasikivi.fi.intel.com \
    --to=sakari.ailus@linux.intel.com \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=wangborong@cdjrlc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®