From: Mark Brown <broonie@kernel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
linux-kernel@vger.kernel.org,
Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
Charles Keepax <ckeepax@opensource.cirrus.com>,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
Bjorn Andersson <bjorn.andersson@linaro.org>
Subject: Re: [PATCH] regmap: support regmap_field_write() on non-readable fields
Date: Tue, 19 Jul 2022 13:53:39 +0100 [thread overview]
Message-ID: <YtapU3/mbFzRgMip@sirena.org.uk> (raw)
In-Reply-To: <20220719121446.375095-1-krzysztof.kozlowski@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 612 bytes --]
On Tue, Jul 19, 2022 at 02:14:46PM +0200, Krzysztof Kozlowski wrote:
> Extend regmap_field_write() and regmap_field_force_write() to check if
> register is readable and only then perform an update. In the other
> case, it is expected that mask of field covers entire register thus a
> full write is allowed.
The other possible assumption there would be that the other bits are
write as zero - that's not 100% safe but does make sense if for example
the fields are being used to capture acknowledgement flags moving
around. That's not incompatible with doing this of course, we can
always relax things later.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2022-07-19 13:39 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-19 12:14 Krzysztof Kozlowski
2022-07-19 12:53 ` Mark Brown [this message]
2022-07-19 12:54 ` Charles Keepax
2022-07-19 13:04 ` Mark Brown
2022-07-19 13:13 ` Krzysztof Kozlowski
2022-07-19 13:41 ` Mark Brown
2022-07-19 14:30 ` Krzysztof Kozlowski
2022-07-19 16:00 ` Krzysztof Kozlowski
2022-07-19 13:42 ` Charles Keepax
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YtapU3/mbFzRgMip@sirena.org.uk \
--to=broonie@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=ckeepax@opensource.cirrus.com \
--cc=gregkh@linuxfoundation.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®