From: "Luck, Tony" <tony.luck@intel.com>
To: Qifu Zhang <zhangqifu@bytedance.com>
Cc: rafael@kernel.org, lenb@kernel.org, jarkko@kernel.org,
dave.hansen@linux.intel.com, linux-acpi@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Documentation: ACPI: EINJ: Fix obsolete example
Date: Tue, 19 Jul 2022 10:13:30 -0700 [thread overview]
Message-ID: <YtbmOlaDdKCVBUFI@agluck-desk3.sc.intel.com> (raw)
In-Reply-To: <20220719115013.744751-1-zhangqifu@bytedance.com>
On Tue, Jul 19, 2022 at 07:50:13PM +0800, Qifu Zhang wrote:
> Since commit 488dac0c9237 ("libfs: fix error cast of negative value in
> simple_attr_write()"), the EINJ debugfs interface no longer accepts
> negative values as input. Attempt to do so will result in EINVAL.
>
> Signed-off-by: Qifu Zhang <zhangqifu@bytedance.com>
Reviewed-by: Tony Luck <tony.luck@intel.com>
> ---
> Documentation/firmware-guide/acpi/apei/einj.rst | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/firmware-guide/acpi/apei/einj.rst b/Documentation/firmware-guide/acpi/apei/einj.rst
> index 55e2331a6438..d6b61d22f525 100644
> --- a/Documentation/firmware-guide/acpi/apei/einj.rst
> +++ b/Documentation/firmware-guide/acpi/apei/einj.rst
> @@ -168,7 +168,7 @@ An error injection example::
> 0x00000008 Memory Correctable
> 0x00000010 Memory Uncorrectable non-fatal
> # echo 0x12345000 > param1 # Set memory address for injection
> - # echo $((-1 << 12)) > param2 # Mask 0xfffffffffffff000 - anywhere in this page
> + # echo 0xfffffffffffff000 > param2 # Mask - anywhere in this page
> # echo 0x8 > error_type # Choose correctable memory error
> # echo 1 > error_inject # Inject now
>
> --
> 2.20.1
>
next prev parent reply other threads:[~2022-07-19 17:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-19 11:50 Qifu Zhang
2022-07-19 17:13 ` Luck, Tony [this message]
2022-07-21 15:10 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YtbmOlaDdKCVBUFI@agluck-desk3.sc.intel.com \
--to=tony.luck@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=jarkko@kernel.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=zhangqifu@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®