From: Luis Chamberlain <mcgrof@kernel.org>
To: David Gow <davidgow@google.com>
Cc: Brendan Higgins <brendanhiggins@google.com>,
Shuah Khan <skhan@linuxfoundation.org>,
Daniel Latypov <dlatypov@google.com>,
Jeremy Kerr <jk@codeconstruct.com.au>,
linux-modules@vger.kernel.org, kunit-dev@googlegroups.com,
linux-kselftest@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] module: kunit: Load .kunit_test_suites section when CONFIG_KUNIT=m
Date: Tue, 19 Jul 2022 10:57:31 -0700 [thread overview]
Message-ID: <YtbwixbViJr9zkv8@bombadil.infradead.org> (raw)
In-Reply-To: <20220713005221.1926290-1-davidgow@google.com>
On Wed, Jul 13, 2022 at 08:52:20AM +0800, David Gow wrote:
> The new KUnit module handling has KUnit test suites listed in a
> .kunit_test_suites section of each module. This should be loaded when
> the module is, but at the moment this only happens if KUnit is built-in.
>
This commit log does not describe what functionality is broken exactly
without this commit. What functionality from kunit is provided when
.kunit_test_suites is available?
> Also load this when KUnit is enabled as a module: it'll not be usable
> unless KUnit is loaded,
What benefit is there to load a kunit module without kunit?
> but such modules are likely to depend on KUnit
> anyway, so it's unlikely to ever be loaded needlessly.
>
> Fixes: 3d6e44623841 ("kunit: unify module and builtin suite definitions")
> Signed-off-by: David Gow <davidgow@google.com>
next prev parent reply other threads:[~2022-07-19 17:57 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-13 0:52 David Gow
2022-07-13 15:24 ` Daniel Latypov
2022-07-19 17:58 ` Luis Chamberlain
2022-07-20 9:26 ` David Gow
2022-07-20 20:29 ` Luis Chamberlain
2022-07-28 8:42 ` David Gow
2022-08-03 20:31 ` Brendan Higgins
2022-07-19 17:57 ` Luis Chamberlain [this message]
2022-07-20 9:32 ` David Gow
2022-08-03 20:32 ` Brendan Higgins
2022-08-12 8:07 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YtbwixbViJr9zkv8@bombadil.infradead.org \
--to=mcgrof@kernel.org \
--cc=brendanhiggins@google.com \
--cc=davidgow@google.com \
--cc=dlatypov@google.com \
--cc=jk@codeconstruct.com.au \
--cc=kunit-dev@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-modules@vger.kernel.org \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®