From: Sam Ravnborg <sam@ravnborg.org>
To: Danilo Krummrich <dakr@redhat.com>
Cc: daniel@ffwll.ch, laurent.pinchart@ideasonboard.com,
airlied@linux.ie, tzimmermann@suse.de, mripard@kernel.org,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH drm-misc-next v5 3/4] drm/gem: rename struct drm_gem_dma_object.{paddr => dma_addr}
Date: Wed, 20 Jul 2022 19:28:51 +0200 [thread overview]
Message-ID: <Ytg7U/+SX0LSAmku@ravnborg.org> (raw)
In-Reply-To: <20220720153532.527458-1-dakr@redhat.com>
On Wed, Jul 20, 2022 at 05:35:31PM +0200, Danilo Krummrich wrote:
> The field paddr of struct drm_gem_dma_object holds a DMA address, which
> might actually be a physical address. However, depending on the platform,
> it can also be a bus address or a virtual address managed by an IOMMU.
>
> Hence, rename the field to dma_addr, which is more applicable.
>
> In order to do this renaming the following coccinelle script was used:
>
> ```
> @@
> struct drm_gem_dma_object *gem;
> @@
>
> - gem->paddr
> + gem->dma_addr
>
> @@
> struct drm_gem_dma_object gem;
> @@
>
> - gem.paddr
> + gem.dma_addr
>
> @exists@
> typedef dma_addr_t;
> symbol paddr;
> @@
>
> dma_addr_t paddr;
> <...
> - paddr
> + dma_addr
> ...>
>
> @@
> symbol paddr;
> @@
> dma_addr_t
> - paddr
> + dma_addr
> ;
>
> ```
>
> This patch is compile-time tested with:
>
> ```
> make ARCH={x86_64,arm,arm64} allyesconfig
> make ARCH={x86_64,arm,arm64} drivers/gpu/drm`
> ```
>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Signed-off-by: Danilo Krummrich <dakr@redhat.com>
Acked-by: Sam Ravnborg <sam@ravnborg.org>
next prev parent reply other threads:[~2022-07-20 17:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-20 15:31 [PATCH drm-misc-next v5 0/4] drm: rename CMA helpers to DMA helpers Danilo Krummrich
2022-07-20 15:31 ` [PATCH drm-misc-next v5 1/4] drm/fb: rename FB CMA helpers to FB " Danilo Krummrich
2022-07-20 17:23 ` Sam Ravnborg
2022-07-21 10:42 ` Danilo Krummrich
2022-07-20 15:31 ` [PATCH drm-misc-next v5 2/4] drm/gem: rename GEM CMA helpers to GEM " Danilo Krummrich
2022-07-20 17:27 ` Sam Ravnborg
2022-07-20 15:35 ` [PATCH drm-misc-next v5 3/4] drm/gem: rename struct drm_gem_dma_object.{paddr => dma_addr} Danilo Krummrich
2022-07-20 17:28 ` Sam Ravnborg [this message]
2022-07-20 15:35 ` [PATCH drm-misc-next v5 4/4] drm/todo: remove task to rename CMA helpers Danilo Krummrich
2022-07-20 17:29 ` Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ytg7U/+SX0LSAmku@ravnborg.org \
--to=sam@ravnborg.org \
--cc=airlied@linux.ie \
--cc=dakr@redhat.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mripard@kernel.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®