From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 054DACCA485 for ; Wed, 20 Jul 2022 17:57:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230455AbiGTR5f (ORCPT ); Wed, 20 Jul 2022 13:57:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52144 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230000AbiGTR5b (ORCPT ); Wed, 20 Jul 2022 13:57:31 -0400 Received: from mail-oi1-x234.google.com (mail-oi1-x234.google.com [IPv6:2607:f8b0:4864:20::234]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4F79624951 for ; Wed, 20 Jul 2022 10:57:29 -0700 (PDT) Received: by mail-oi1-x234.google.com with SMTP id s204so11812087oif.5 for ; Wed, 20 Jul 2022 10:57:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxtx.org; s=google; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=sgTGIjyBI1Xr5kae9NtvGuvQ751HmdoxY8E4y+04bcM=; b=VuHxsoUeYLJU3NL2MX0RU5EKmY7niw3Gwan0qSjKNQ+yHnuScPtLYptfI3fKI++uAI ZeZ8nICnyQhmL1BpX4XQNXKRt39zlzUQWbx08LgEuCZ1tvXne53ZQf6SRKJVlIm3SYkA mL9xo1GRlnkK1+eByxB1hXq6hJ+8ib0Bj6Vz4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to; bh=sgTGIjyBI1Xr5kae9NtvGuvQ751HmdoxY8E4y+04bcM=; b=KBAmND7IHGC9+H1dT2Qmxa7AYgEvlnlnaDdhmyrQ481sne+EEEklvwitgURakrPV/o kp2Bni8gKpm1mPO3RAzNA6u3GSKZEH5MzRPnyMuanuDO5sIT0xvg33t9KPaS5HA0hz5n EV9AmTYIkfRYZwH+bJ5FpM6nXWEt8ggS7zjFNAV7F/J0lfuzQ1BQ5SGKW+dWFvjq0dSD jCtjv1qUhfMhlSubrahk5xX1RIcQvDRQB4/TYwV45AMtVnKo1TmUbLk3DB/vgmcw8PW8 qRBVPhWEwooYgrJzh+34eGWy4Is4e/xKWDPQ8uuHpqzpOl4QygurLlUVhCru1nnadsLg hguw== X-Gm-Message-State: AJIora9ArPXQemQ6c1OHC2yOvctSNWsbMRS4DP9fJUyCUFwNWwzsbBMx TquEcOg737OOomCaS0ZQhoJXpg== X-Google-Smtp-Source: AGRyM1vYLqC/RqZeHtVvHjmMhC0sp3QLz3G9l0Bz1+cMerVnWbXkdjUx5gjtpb0zt3sMy6gYkJFMPg== X-Received: by 2002:a05:6808:302:b0:33a:78cc:2fa7 with SMTP id i2-20020a056808030200b0033a78cc2fa7mr2939761oie.50.1658339848625; Wed, 20 Jul 2022 10:57:28 -0700 (PDT) Received: from fedora64.linuxtx.org (99-47-93-78.lightspeed.rcsntx.sbcglobal.net. [99.47.93.78]) by smtp.gmail.com with ESMTPSA id y7-20020a544d87000000b0032f7605d1a3sm6795335oix.31.2022.07.20.10.57.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Jul 2022 10:57:27 -0700 (PDT) Sender: Justin Forbes Date: Wed, 20 Jul 2022 12:57:26 -0500 From: Justin Forbes To: Linus Torvalds Cc: Peter Zijlstra , Jiri Slaby , Naresh Kamboju , Greg Kroah-Hartman , Linux Kernel Mailing List , stable , Andrew Morton , Guenter Roeck , Shuah Khan , patches@kernelci.org, lkft-triage@lists.linaro.org, Pavel Machek , Jon Hunter , Florian Fainelli , Sudip Mukherjee , Slade Watkins , John Harrison , Tejas Upadhyay , Anusha Srivatsa , Jani Nikula , Daniele Ceraolo Spurio Subject: Re: [PATCH 5.18 000/231] 5.18.13-rc1 review Message-ID: References: <20220719114714.247441733@linuxfoundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 20, 2022 at 10:28:33AM -0700, Linus Torvalds wrote: > [ Adding PeterZ and Jiri to the participants. ] > > Looks like 5.18.13 added that commit 9bb2ec608a20 ("objtool: Update > Retpoline validation") but I don't see 3131ef39fb03 ("x86/asm/32: Fix > ANNOTATE_UNRET_SAFE use on 32-bit") in that list. It should be noted that the build doesn't fail, it just warns. I am guessing the 32bit failure is what promoted someone to look at the logs to begin with and notice the warn initially. I just verified that it exists in our builds of 5.18.13-rc1, but not on mainline builds. I am gueesing it is because commit 9bb2ec608a20 ("objtool: Update Retpoline validation") should be followed up with at least commit f43b9876e857c ("x86/retbleed: Add fine grained Kconfig knobs") Justin > That said, 3131ef39fb03 should have fixed a completely different issue > on 32-bit, not the "naked ret" thing. > > PeterZ, Jiri, any ideas? Limited quoting below, see thread at > > https://lore.kernel.org/all/CA+G9fYsJBBbEXowA-3kxDNqcfbtcqmxBrEnJSkCnLUsMzNfJZw@mail.gmail.com/ > > for more details. > > Linus > > On Wed, Jul 20, 2022 at 9:37 AM Justin Forbes wrote: > > > > On Tue, Jul 19, 2022 at 12:32:48PM -0700, Linus Torvalds wrote: > > > On Tue, Jul 19, 2022 at 10:57 AM Naresh Kamboju > > > wrote: > > > > > > > > > > > > 2. Large number of build warnings on x86 with gcc-11, > > > > I do not see these build warnings on mainline, > > > .. > > > > 'naked' return found in RETPOLINE build > > > > > > Hmm. Does your cross-compiler support '-mfunction-return=thunk-extern'? > > > > > > Your build does magic things with 'scripts/kconfig/merge_config.sh', > > > and I'm wondering if you perhaps end up enabling CONFIG_RETHUNK with a > > > compiler that doesn't actually support it, or something like that? > > > > I am seeing these 'naked' return found in RETPOLINE build on the > > standard fedora 36 toolchain as well. No cross compiling, nothing fancy. > > These were not seen with mainline, or with the 5.18.12-rc1 retbleed > > patches. > > > > Justin